Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory count for string operations #1924

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Fix memory count for string operations #1924

merged 2 commits into from
Mar 23, 2023

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz added this to the 0.3.1 milestone Mar 23, 2023
@lukaszcz lukaszcz self-assigned this Mar 23, 2023
@lukaszcz lukaszcz requested a review from paulcadman March 23, 2023 15:46
paulcadman
paulcadman approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@paulcadman paulcadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this fix, the milestone examples now work 🚀 . These will be tested one we have merged #1920

@lukaszcz lukaszcz temporarily deployed to github-pages March 23, 2023 16:16 — with GitHub Actions Inactive
@lukaszcz lukaszcz temporarily deployed to github-pages March 23, 2023 17:33 — with GitHub Actions Inactive
@paulcadman paulcadman merged commit 6eae6c4 into main Mar 23, 2023
@paulcadman paulcadman deleted the fix-runtime-strconcat branch March 23, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcadman paulcadman paulcadman approved these changes

Assignees

@lukaszcz lukaszcz

Labels
asm fix:bug runtime
Projects
None yet
Milestone
0.3.1
Development

Successfully merging this pull request may close these issues.

Runtime juvix assertion error in Hanoi example
2 participants
@lukaszcz @paulcadman