Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the old C backend #1862

Merged
merged 11 commits into from
Mar 14, 2023
Merged

Remove the old C backend #1862

merged 11 commits into from
Mar 14, 2023

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz commented Feb 23, 2023 •
edited
Loading

@lukaszcz lukaszcz added this to the 0.3 - Valencia milestone Feb 23, 2023
@lukaszcz lukaszcz self-assigned this Feb 23, 2023
@lukaszcz lukaszcz force-pushed the remove-old-c-backend branch 2 times, most recently from 508ed3c to 3911918 Compare March 14, 2023 08:52
@lukaszcz lukaszcz mentioned this pull request Mar 14, 2023
Merged
@lukaszcz lukaszcz force-pushed the remove-old-c-backend branch from 175b1a4 to 4848ec0 Compare March 14, 2023 15:44
@lukaszcz lukaszcz marked this pull request as ready for review March 14, 2023 15:44
janmasrovira
janmasrovira approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@janmasrovira janmasrovira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@janmasrovira janmasrovira merged commit 1eadbc4 into main Mar 14, 2023
@janmasrovira janmasrovira deleted the remove-old-c-backend branch March 14, 2023 16:22
@janmasrovira janmasrovira mentioned this pull request Mar 15, 2023
Merged
lukaszcz pushed a commit that referenced this pull request Mar 15, 2023
@janmasrovira
Remove dead code in Internal (#1891)
e9672e6 
- This has become dead code after #1862
lukaszcz added a commit that referenced this pull request Mar 15, 2023
@lukaszcz @janmasrovira
Print JuvixCore correctly (#1875)
98b1dae 
Print JuvixCore InfoTable in such a way that it can be parsed back by
the JuvixCore parser.

* Depends on PR #1832 
* Depends on PR #1862 
* Closes #1841 
* Adds "JuvixCore print" tests which read the files from
Core/positive/*.jvc, print them, read them back and check if the
evaluation results are preserved.

---------

Co-authored-by: Jan Mas Rovira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcadman paulcadman paulcadman approved these changes

@janmasrovira janmasrovira janmasrovira approved these changes

@jonaprieto jonaprieto Awaiting requested review from jonaprieto

Assignees

@lukaszcz lukaszcz

Labels
refactor
Projects
None yet
Milestone
0.3 - Valencia
Development

Successfully merging this pull request may close these issues.

Remove the old C backend
3 participants
@lukaszcz @paulcadman @janmasrovira