Run shelltests on macOS build #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaprieto
approved these changes
Dec 12, 2022
lukaszcz
pushed a commit
that referenced
this pull request
Dec 12, 2022
janmasrovira
pushed a commit
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables the shell tests on the macOS build.
I can't remember why we disabled the shell tests on Mac. It may have been because the PATH was not setup correctly (1. Adding
$GITHUB_WORKSPACE/.local/bininstead of$HOME/.local/binto the PATH and 2. Adding to the PATH in the same step as using it). The setup issue is now fixed.