Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

look in patterns when building the dependency graph #1536

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Sep 14, 2022

The dependency graph is computed before holes have been inferred. Consider the following example:

f : _;
f true := zero;
f false := zero;

Unless we look at the patterns we will not know that f depends on Bool.

@janmasrovira janmasrovira added this to the 0.2.6 milestone Sep 14, 2022
@janmasrovira janmasrovira self-assigned this Sep 14, 2022
@janmasrovira janmasrovira force-pushed the dependency-builder-patterns branch from 278fb7c to d71ecf5 Compare September 14, 2022 15:49
@janmasrovira janmasrovira marked this pull request as ready for review September 14, 2022 15:49
@janmasrovira janmasrovira merged commit dab4b6f into main Sep 15, 2022
@janmasrovira janmasrovira deleted the dependency-builder-patterns branch September 15, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants