Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow tab characters as spaces #1523

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Disallow tab characters as spaces #1523

merged 3 commits into from
Sep 7, 2022

Conversation

janmasrovira
Copy link
Collaborator

The use of tab characters as spaces would be too hard to properly handle in the current implementation of semantic highlighting for both emacs and vscode. For this reason, we have decided to forbid tab characters. This PR implements this change.

Closes #1464

@janmasrovira janmasrovira added this to the 0.2.5 milestone Sep 7, 2022
@janmasrovira janmasrovira self-assigned this Sep 7, 2022
Copy link
Collaborator

@jonaprieto jonaprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) That was quick!

@jonaprieto jonaprieto merged commit ccce5a4 into main Sep 7, 2022
@jonaprieto jonaprieto deleted the disallow-tabs branch September 7, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode syntax highlighting uses different colors within the same token
2 participants