Refactor destruct in Core/Extra/Base
#1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added field names. I didn't break the cases into separate functions because I think we might care a bit about the constant-factor efficiency of this function since it is called at every step in each recursor. The efficiency difference is probably not big (especially if GHC manages to inline some of the functions and avoid the extra allocation due the UNPACK pragma, but it's unclear if it would do that in all cases), but the readability gain doesn't seem to be that big either (personally, I don't see much point, but that's a subjective opinion).