Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper error reporting for the Core-to-GEB translation #1844

Closed
lukaszcz opened this issue Feb 13, 2023 · 0 comments · Fixed by #1871
Closed

Proper error reporting for the Core-to-GEB translation #1844

lukaszcz opened this issue Feb 13, 2023 · 0 comments · Fixed by #1871
Assignees
@lukaszcz
Labels
core Related to JuvixCore enhancement New feature or request error-messaging pending-review translation:core-to-geb
Milestone
0.3.1

Comments

@lukaszcz
Copy link
Collaborator

We should add a step in the pipeline in Core just before the transformations for GEB, which would check if the input has the right form for GEB, i.e., it doesn't include any (currently) unsupported features (IO, non-monomorphisable polymorphism). This step should throw a user-level JuvixError. Now, the pipeline will just crash.
@lukaszcz lukaszcz added this to the 0.4 - Geb integration milestone Feb 13, 2023
@lukaszcz lukaszcz self-assigned this Feb 27, 2023
@lukaszcz lukaszcz mentioned this issue Feb 28, 2023
Merged
lukaszcz added a commit that referenced this issue Mar 20, 2023
@lukaszcz
Add errors to the Core pipeline and check GEB prerequisites (#1871)
ac6d08e 
* Depends on #1832 
* Closes #1844
* Adds errors to the Core pipeline
* Checks for no recursion in the GEB pipeline
* Checks for no polymorphism in the GEB pipeline
* Checks for no dynamic type in the GEB pipeline
* Checks for no IO in the GEB pipeline
* Checks for no unsupported builtins in the GEB pipeline
@lukaszcz lukaszcz modified the milestones: 0.6.0, 0.5.5, 0.3.1 Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukaszcz lukaszcz

Labels
core Related to JuvixCore enhancement New feature or request error-messaging pending-review translation:core-to-geb
Projects
None yet
Milestone
0.3.1
Development

Successfully merging a pull request may close this issue.

Add errors to the Core pipeline and check GEB prerequisites anoma/juvix
1 participant
@lukaszcz