Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

governance: init proposal #954

Merged
merged 13 commits into from
Apr 1, 2022
Merged

governance: init proposal #954

merged 13 commits into from
Apr 1, 2022

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented Mar 10, 2022 •
edited
Loading

  • Added CLI commands:
    • Submit on chain proposal
    • Create offline proposal
    • Query existing proposals
  • Added initial governance VP
  • Added governance parameters to genesis

@Fraccaman Fraccaman requested a review from grarco March 10, 2022 15:48
@Fraccaman Fraccaman force-pushed the fraccaman+grarco/governance-init-proposal branch from 92ee130 to 6180a9f Compare March 10, 2022 15:52
@Fraccaman Fraccaman marked this pull request as draft March 11, 2022 09:21
@Fraccaman
Copy link
Member Author

pls update wasm

@Fraccaman Fraccaman marked this pull request as ready for review March 11, 2022 15:09
@Fraccaman Fraccaman requested review from tzemanovic and cwgoes March 11, 2022 15:09
@Fraccaman
Copy link
Member Author

pls update wasm

tzemanovic
tzemanovic reviewed Mar 14, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@Fraccaman Fraccaman mentioned this pull request Mar 15, 2022
Merged
@Fraccaman Fraccaman force-pushed the fraccaman+grarco/governance-init-proposal branch from 9be0a45 to c68d667 Compare March 16, 2022 08:58
tzemanovic
tzemanovic reviewed Mar 21, 2022
View reviewed changes
apps/src/lib/cli.rs Outdated Show resolved Hide resolved
tzemanovic
tzemanovic reviewed Mar 21, 2022
View reviewed changes
apps/src/lib/cli.rs Outdated Show resolved Hide resolved
tzemanovic
tzemanovic reviewed Mar 21, 2022
View reviewed changes
tests/src/e2e/setup.rs Outdated Show resolved Hide resolved
tzemanovic
tzemanovic requested changes Mar 21, 2022
View reviewed changes
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking great! I just added couple suggestions

@grarco
Copy link

grarco commented Mar 22, 2022

pls update wasm

@grarco grarco force-pushed the fraccaman+grarco/governance-init-proposal branch from d652430 to 6477f59 Compare March 22, 2022 16:27
@grarco
Copy link

grarco commented Mar 22, 2022

pls update wasm

@grarco grarco force-pushed the fraccaman+grarco/governance-init-proposal branch from 405de3a to 077de9d Compare March 22, 2022 17:06
@grarco
Copy link

grarco commented Mar 22, 2022

pls update wasm

@Fraccaman
Copy link
Member Author

pls update wasm

tzemanovic
tzemanovic approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the updates!

tzemanovic added a commit to heliaxdev/anoma-network-config that referenced this pull request Apr 1, 2022
@tzemanovic
add gov. params for anoma/anoma#954
cdec169
@tzemanovic
Copy link
Member

I've added network config update for the next release heliaxdev/anoma-network-config#9

@tzemanovic tzemanovic merged commit 8eeab64 into master Apr 1, 2022
@tzemanovic tzemanovic deleted the fraccaman+grarco/governance-init-proposal branch April 1, 2022 11:15
tzemanovic
tzemanovic reviewed Apr 7, 2022
View reviewed changes
apps/src/lib/config/genesis.rs
@@ -493,6 +516,14 @@ pub mod genesis_config {
tx_whitelist: config.parameters.tx_whitelist.unwrap_or_default(),
};

let gov_params = GovParams {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check

tzemanovic
tzemanovic reviewed Apr 7, 2022
View reviewed changes
shared/src/ledger/governance/mod.rs
H: 'static + StorageHasher,
CA: 'static + WasmCacheAccess,
{
is_valid_proposal_init_key_set(context, keys)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check

@tzemanovic tzemanovic mentioned this pull request Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grarco grarco grarco approved these changes

@tzemanovic tzemanovic tzemanovic approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fraccaman @grarco @tzemanovic