Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/e2e: switch from rexpect to expectrl #686

Closed
tzemanovic opened this issue Dec 2, 2021 · 1 comment · Fixed by #1095
Closed

tests/e2e: switch from rexpect to expectrl #686

tzemanovic opened this issue Dec 2, 2021 · 1 comment · Fixed by #1095

Comments

@tzemanovic
Copy link
Member

tzemanovic commented Dec 2, 2021 •
edited by sync-by-unito bot
Loading

Let's switch e2e tests from rexpect to expectrl (https://github.com/zhiburt/expectrl).

We had to patch rexpect for rust-cli/rexpect#38 to build with Rust 1.55+ in #618. Expectrl reportedly doesn't have this issue and as a bonus supports windows.

┆Issue is synchronized with this Asana task by Unito
@tzemanovic tzemanovic mentioned this issue Dec 10, 2021
Closed
@tzemanovic tzemanovic moved this to Todo in Namada-Old Jan 10, 2022
@sync-by-unito sync-by-unito bot closed this as completed Feb 3, 2022
Repository owner moved this from Todo to Devnet in Namada-Old Feb 3, 2022
@juped juped reopened this Feb 3, 2022
@tzemanovic tzemanovic moved this from Devnet to WIP in Namada-Old Feb 4, 2022
@batconjurer batconjurer mentioned this issue Feb 4, 2022
Closed
@tzemanovic
Copy link
Member Author

we made a fork of expectrl when we started working on this in #879 we'll want to use for this, because the lazy expect was way too heavy for our node logs https://github.com/heliaxdev/expectrl/tree/tomas/expect-eager

@tzemanovic tzemanovic mentioned this issue May 11, 2022
Merged
tzemanovic added a commit that referenced this issue May 11, 2022
@tzemanovic
changelog: add #686
bc46b97
tzemanovic added a commit that referenced this issue May 12, 2022
@tzemanovic
changelog: add #686
9f3e50e
juped added a commit that referenced this issue Jun 8, 2022
@juped
Merge branch 'tomas/e2e-tests-switch-to-expectrl' (#1095)
1269900 
* tomas/e2e-tests-switch-to-expectrl:
  test/e2e: refactor AnomaCmd background session handling
  update to newer rebased expectrl branch
  changelog: add #686
  tests/e2e: update tests for expectrl
  tests/deps: replace rexpect with expectrl
tzemanovic added a commit that referenced this issue Jun 9, 2022
@tzemanovic
Merge branch 'tomas/e2e-tests-switch-to-expectrl' (#1095)
7533bf1 
* tomas/e2e-tests-switch-to-expectrl:
  test/e2e: refactor AnomaCmd background session handling
  update to newer rebased expectrl branch
  changelog: add #686
  tests/e2e: update tests for expectrl
  tests/deps: replace rexpect with expectrl
tzemanovic added a commit that referenced this issue Jun 9, 2022
@tzemanovic
Merge branch 'tomas/e2e-tests-switch-to-expectrl' (#1095)
c49c078 
* tomas/e2e-tests-switch-to-expectrl:
  test/e2e: refactor AnomaCmd background session handling
  update to newer rebased expectrl branch
  changelog: add #686
  tests/e2e: update tests for expectrl
  tests/deps: replace rexpect with expectrl
juped added a commit that referenced this issue Jun 9, 2022
@juped
Merge branch 'tomas/e2e-tests-switch-to-expectrl' (#1095)
2083316 
* tomas/e2e-tests-switch-to-expectrl:
  test/e2e: refactor AnomaCmd background session handling
  update to newer rebased expectrl branch
  changelog: add #686
  tests/e2e: update tests for expectrl
  tests/deps: replace rexpect with expectrl
tzemanovic added a commit that referenced this issue Jun 9, 2022
@tzemanovic
Merge branch 'tomas/e2e-tests-switch-to-expectrl' (#1095)
a5f62aa 
* tomas/e2e-tests-switch-to-expectrl:
  test/e2e: refactor AnomaCmd background session handling
  update to newer rebased expectrl branch
  changelog: add #686
  tests/e2e: update tests for expectrl
  tests/deps: replace rexpect with expectrl
tzemanovic added a commit that referenced this issue Jun 9, 2022
@tzemanovic
Merge branch 'tomas/e2e-tests-switch-to-expectrl' (#1095)
9fab08d 
The new expectrl e2e command runner requires to put the ledger into
background while we're testing client commands that interact with the
ledger. This had to be added to the new eth_bridge_tests::everything,
ledger_tests::proposal_offline and ledger_tests::proposal_submission

* tomas/e2e-tests-switch-to-expectrl:
  test/e2e: refactor AnomaCmd background session handling
  update to newer rebased expectrl branch
  changelog: add #686
  tests/e2e: update tests for expectrl
  tests/deps: replace rexpect with expectrl
Repository owner moved this from WIP to Devnet in Namada-Old Jun 9, 2022
james-chf added a commit that referenced this issue Jun 23, 2022
@james-chf
Merge branch 'master' into james/integration/eth-bridge-integration+v…
3f867bf 
…0.6.0

* master:
  Anoma 0.6.0
  Add changelog
  changelog: #1116
  fixed broken links in README.md
  changelog: add #1132
  install mdbook-admonish assets
  changelog: add #1133
  docs: include rust-nightly-version from file
  test/e2e: refactor AnomaCmd background session handling
  changelog: add #1118
  make install: use the lock file
  Move EthBridge VP into vp.rs
  [ci]: update wasm checksums
  Add ethbridge e2e test
  Add tx_write_storage_key.wasm
  Add InternalAddress::EthBridge
  update to newer rebased expectrl branch
  client/utils/join-network: remove self from persistent peers
  changelog: add #997
  add --archive-dir to `init-network` to use temp-dir in e2e test
  changelog: add #686
  tests/e2e: update tests for expectrl
  tests/deps: replace rexpect with expectrl
  changelog: add #927
  [ci]: update wasm checksums
  pos/epoched: rm debug_asserts to test with invalid state changes
  PoS: make epoched field data public
  PoS/VP: Prevent possible bond and unbond epoch subtraction underflow
  PoS/VP: fix validator set validation
  PoS/VP: replace expected voting power accumulator with total stake
  PoS: fix validator set update
  PoS: make `EpochedDelta::get_delta_at_epoch` public outside the crate
  PoS/VP: fix expected voting power changes for bond/unbond combo
  PoS/VP: fix validator set update check to allow new validators
  tests: Add state machine tests for PoS VP
  PoS: make BTreeSet shims module public
  PoS/VP: fix validator set update - active becomes inactive or vice-versa
  PoS/VP: fix total deltas and bonds accumulation
  PoS/validation: use the determined voting power for validator set check
  tests: add storage key changes helpers
  PoS/VP: Fix validation of inactive validator set update
  PoS/tests: replace ad hoc arb. PoS params gen
  PoS: fix voting power conversion from tokens to avoid overflow
  PoS/parameters: Add validation and arbitrary params gen for testing
  tests: add helpers for testing native VPs
  test/e2e/ledger_tests/node_connectivity: check node's start-up log
  test/e2e/ledger_tests: test init-genesis-validator with join-network
  test/e2e: make a help for copying wasms for a chain
  client/utils: update init-genesis-validator and join-network
  Don't create empty tendermint directory during init-network
  client/utils/join-network: no chain dir in configs server from env var
  client/utils/join-network: update the config for validators
  client/utils/join-network: use pre-genesis wallet for genesis validators
  Add ANOMA_NETWORK_CONFIGS_SERVER envvar
  Add stub --genesis-validator arg to anomac utils join-network
  Ensure directory hierarchy exists
  client/utils/init-network: only generate validator keys if they're not pre-defined
  ledger/config/genesis: add thiserror::Error
  client/utils/init-genesis-validator: write out partial pre-genesis
  genesis: make validation tokens and non-staked-balance optional
  client/utils/init-genesis-validator: add tendermint node key
  Use ValidatorConfig instead of genesis::Validator, print TOML
  Removed chain ID and don't write validator keys into Tendermint dir
  [ci]: update wasm checksums
  reuse IBC port
  [ci]: update wasm checksums
  tests: add a tx field to a `TestTxEnv`
  tests: derive debug on `TestTxEnv` with derivative
  deps: updated proptest state-machine branch
  remove temp when commit_tx
  fix IBC token VP
james-chf added a commit that referenced this issue Jun 23, 2022
@james-chf
Merge branch 'master' into james/integration/eth-bridge-integration+b…
3cd6d8f 
…at-1.61-update-abcipp

* master:
  Anoma 0.6.0
  Add changelog
  changelog: #1116
  fixed broken links in README.md
  changelog: add #1132
  install mdbook-admonish assets
  changelog: add #1133
  docs: include rust-nightly-version from file
  test/e2e: refactor AnomaCmd background session handling
  changelog: add #1118
  make install: use the lock file
  Move EthBridge VP into vp.rs
  [ci]: update wasm checksums
  Add ethbridge e2e test
  Add tx_write_storage_key.wasm
  Add InternalAddress::EthBridge
  update to newer rebased expectrl branch
  client/utils/join-network: remove self from persistent peers
  changelog: add #997
  add --archive-dir to `init-network` to use temp-dir in e2e test
  changelog: add #686
  tests/e2e: update tests for expectrl
  tests/deps: replace rexpect with expectrl
  changelog: add #927
  [ci]: update wasm checksums
  pos/epoched: rm debug_asserts to test with invalid state changes
  PoS: make epoched field data public
  PoS/VP: Prevent possible bond and unbond epoch subtraction underflow
  PoS/VP: fix validator set validation
  PoS/VP: replace expected voting power accumulator with total stake
  PoS: fix validator set update
  PoS: make `EpochedDelta::get_delta_at_epoch` public outside the crate
  PoS/VP: fix expected voting power changes for bond/unbond combo
  PoS/VP: fix validator set update check to allow new validators
  tests: Add state machine tests for PoS VP
  PoS: make BTreeSet shims module public
  PoS/VP: fix validator set update - active becomes inactive or vice-versa
  PoS/VP: fix total deltas and bonds accumulation
  PoS/validation: use the determined voting power for validator set check
  tests: add storage key changes helpers
  PoS/VP: Fix validation of inactive validator set update
  PoS/tests: replace ad hoc arb. PoS params gen
  PoS: fix voting power conversion from tokens to avoid overflow
  PoS/parameters: Add validation and arbitrary params gen for testing
  tests: add helpers for testing native VPs
  test/e2e/ledger_tests/node_connectivity: check node's start-up log
  test/e2e/ledger_tests: test init-genesis-validator with join-network
  test/e2e: make a help for copying wasms for a chain
  client/utils: update init-genesis-validator and join-network
  Don't create empty tendermint directory during init-network
  client/utils/join-network: no chain dir in configs server from env var
  client/utils/join-network: update the config for validators
  client/utils/join-network: use pre-genesis wallet for genesis validators
  Add ANOMA_NETWORK_CONFIGS_SERVER envvar
  Add stub --genesis-validator arg to anomac utils join-network
  Ensure directory hierarchy exists
  client/utils/init-network: only generate validator keys if they're not pre-defined
  ledger/config/genesis: add thiserror::Error
  client/utils/init-genesis-validator: write out partial pre-genesis
  genesis: make validation tokens and non-staked-balance optional
  client/utils/init-genesis-validator: add tendermint node key
  Use ValidatorConfig instead of genesis::Validator, print TOML
  Removed chain ID and don't write validator keys into Tendermint dir
  [ci]: update wasm checksums
  reuse IBC port
  [ci]: update wasm checksums
  tests: add a tx field to a `TestTxEnv`
  tests: derive debug on `TestTxEnv` with derivative
  deps: updated proptest state-machine branch
  remove temp when commit_tx
  fix IBC token VP

# Conflicts:
#	.changelog/v0.6.0/improvements/1088-updating-to-latest-abcipp.md
#	Cargo.lock
#	shared/src/types/storage.rs
#	tests/src/e2e/gossip_tests.rs
#	tests/src/e2e/ledger_tests.rs
#	wasm/checksums.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Namada-Old
Status: Tested in Devnet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

e2e tests: switch from rexpect to expectrl anoma/anoma
2 participants
@juped @tzemanovic