Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR]Add exception handlers #411

Merged
merged 13 commits into from
Sep 2, 2024
Merged

[REFACTOR]Add exception handlers #411

merged 13 commits into from
Sep 2, 2024

Conversation

HAEKADI
Copy link
Contributor

@HAEKADI HAEKADI commented Aug 30, 2024

closes #410

@HAEKADI HAEKADI self-assigned this Aug 30, 2024
@HAEKADI HAEKADI changed the base branch from main to update-api-design August 30, 2024 15:27
@HAEKADI HAEKADI marked this pull request as ready for review August 30, 2024 15:31
@HAEKADI HAEKADI requested a review from XavierJp August 30, 2024 15:35
@HAEKADI HAEKADI added enhancement New feature or request core API payload labels Aug 30, 2024
XavierJp
XavierJp approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@XavierJp XavierJp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice to only load the handler once rather than using decorators

Base automatically changed from update-api-design to main September 2, 2024 14:22
@HAEKADI HAEKADI requested a review from MKCG September 2, 2024 15:45
@HAEKADI HAEKADI merged commit 2886b85 into main Sep 2, 2024
10 checks passed
@HAEKADI HAEKADI deleted the handle-exceptions branch September 2, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKCG MKCG MKCG approved these changes

@XavierJp XavierJp XavierJp approved these changes

Assignees

@HAEKADI HAEKADI

Labels
API payload core enhancement New feature or request refactoring/clean code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CORE]Améliorer la gestion des exceptions
3 participants
@HAEKADI @XavierJp @MKCG