refactor: use pydantic class to model search params #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAEKADI
force-pushed
the
params-w/-pydantic
branch
from
138b657 to
5555483
Compare
HAEKADI
force-pushed
the
params-w/-pydantic
branch
from
91435cd to
182e1d6
Compare
HAEKADI
force-pushed
the
params-w/-pydantic
branch
from
8851247 to
cdf3ad9
Compare
XavierJp
approved these changes
Oct 3, 2023
|
Could be nice to raise a custom Error that implement TypeError and that is catched and raised as a 400 instead of the default catchall (ValueError, TypeErorr) that might lead to an incorrect 400 |
|
@johangirod I know Python is not your main language. But any feedback you have on this restructuring PR is more than welcome. |
Well, I went thought it, but I must admit, I was quite lost between the language and also the project architecture, which I know nothing of. I like the diff count thought 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Pydanticclasses have been used to refactor the response model, this PR usesPydantic V2and its validator methods to parse and validate API requests.