Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter issues #13

Merged
merged 2 commits into from
Dec 8, 2024
Merged

Fix linter issues #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab0e17d
fix trailing spaces
anna-ayn Dec 8, 2024
e2e8f4b
Remove unnecessary blank lines in initMyBooksAffordances function
anna-ayn Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openlibrary/plugins/openlibrary/js/lists/ShowcaseItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,10 @@ function getSeedType(seed) {
* @param {string} seedKey
* @param {string} listTitle
* @param {string} [coverUrl]
* @param {string} desiredHeight
* @param {string} desiredHeight
* @returns {HTMLLIElement}
*/
export function createActiveShowcaseItem(listKey, seedKey, listTitle, coverUrl = DEFAULT_COVER_URL, desiredHeight = "") {
export function createActiveShowcaseItem(listKey, seedKey, listTitle, coverUrl = DEFAULT_COVER_URL, desiredHeight = '') {
if (!i18nStrings) {
const i18nInput = document.querySelector('input[name=list-i18n-strings]')
i18nStrings = JSON.parse(i18nInput.value)
Expand Down
4 changes: 2 additions & 2 deletions openlibrary/plugins/openlibrary/js/my-books/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ export async function initMyBooksAffordances(dropperElements, showcaseElements)
const key = listData[listKey].members[0]
const coverID = key.slice(key.indexOf('OL'))
const cover = `https://covers.openlibrary.org/b/olid/${coverID}-S.jpg`

const img = new Image()
img.src = cover

await new Promise((resolve) => {
img.onload = () => {
let desiredHeight = 22 * img.height / img.width
Expand Down
Loading