This repository has been archived by the owner on Jun 4, 2022. It is now read-only.
Add callback to lumo.build.api/build #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichiardi
force-pushed
the
build-callback
branch
2 times, most recently
from
1fb765c to
92ba898
Compare
arichiardi
force-pushed
the
build-callback
branch
from
92ba898 to
5522ae0
Compare
arichiardi
commented
Sep 12, 2017
src/cljs/bundled/lumo/build/api.cljs
Outdated
| ([source opts compiler-env] | ||
| (build source opts compiler-env (fn [& args] args))) | ||
| ([source opts compiler-env cb] |
There was a problem hiding this comment.
I was even wondering if we could accept the classic node (fn [err data] ...) callback so that you could promisify on it...but then I told myself: "KISS!!"
arichiardi
force-pushed
the
build-callback
branch
from
5522ae0 to
05d3325
Compare
anmonteiro
force-pushed
the
compiler-tweaks
branch
from
3f1292c to
26c1680
Compare
arichiardi
force-pushed
the
build-callback
branch
4 times, most recently
from
075c4a0 to
57b4230
Compare
anmonteiro
reviewed
Sep 15, 2017
src/cljs/bundled/lumo/closure.cljs
Outdated
| @@ -2152,17 +2152,16 @@ | |||
|
|
|||
| (defn build | |||
| "Given a source which can be compiled, produce runnable JavaScript." | |||
| ([source opts] | |||
| ([source opts cb] | |||
There was a problem hiding this comment.
this still needs the 2-arity function
There was a problem hiding this comment.
Why? Is it used? Do you prefer it? To avoid duplication, the default callback is passed in.i can add it back if you want to
There was a problem hiding this comment.
JVM CLJS has a 2-arity version. I think we should have one too
There was a problem hiding this comment.
Ok np will add it back
arichiardi
force-pushed
the
build-callback
branch
from
57b4230 to
0683c36
Compare
This change was made necessary by the fact that the bootstrap compiler is asynchronous by default. Therefore, it does not make sense to call lumo.build.api/build without a callback. The patch does not break old code, so it still contains the arity without cb, in which case it hooks a default callback that just returns the input.
arichiardi
force-pushed
the
build-callback
branch
from
0683c36 to
bac34a9
Compare
|
Ok this should be ok now, no changes in |
anmonteiro
pushed a commit
that referenced
this pull request
Sep 16, 2017
This change was made necessary by the fact that the bootstrap compiler is asynchronous by default. Therefore, it does not make sense to call lumo.build.api/build without a callback. The patch does not break old code, so it still contains the arity without cb, in which case it hooks a default callback that just returns the input.
anmonteiro
pushed a commit
that referenced
this pull request
Sep 17, 2017
This change was made necessary by the fact that the bootstrap compiler is asynchronous by default. Therefore, it does not make sense to call lumo.build.api/build without a callback. The patch does not break old code, so it still contains the arity without cb, in which case it hooks a default callback that just returns the input.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was made necessary by the fact that the bootstrap compiler is
asynchronous by default. Therefore, it does not make sense to call
lumo.build.api/build without a callback.
The patch does not break old code, so it still contains the arity without cb,
but includes a warning if that arity is invoked.