Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on conduit-mirage instead of mirage-conduit #16

Merged
merged 7 commits into from
Sep 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 42 additions & 23 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: 2
version: 2.1

common_cache_key: &common_cache_key
key: dependency-cache-{{ checksum "../ocaml-version" }}-{{ checksum ".circleci/config.yml" }}-{{ checksum "httpaf.opam" }}-{{ checksum "httpaf-async.opam" }}-{{ checksum "httpaf-lwt.opam" }}-{{ checksum "httpaf-lwt-unix.opam" }}-{{ checksum "httpaf-mirage.opam" }}
Expand All @@ -10,6 +10,10 @@ esy_post_build_cache_key: &esy_post_build_cache_key
key: esy-post-build-cache-{{ checksum "esy.json" }}-{{ checksum "../esy-checksum" }}-{{ checksum ".circleci/config.yml" }}

opam-steps: &opam-steps
parameters:
all_tests:
type: boolean
default: true
steps:
- checkout
- run:
Expand All @@ -30,58 +34,72 @@ opam-steps: &opam-steps
- run:
name: "Install deps"
command: |
sudo apt-get install -y pkg-config libgmp-dev autotools-dev autoconf lsof libssl-dev
sudo apt-get install -y pkg-config libgmp-dev lsof libssl-dev
opam update
opam install -y dune
opam install -t --deps-only .
opam install -y lwt_ssl
opam install -t --deps-only --best-effort .
- run:
name: 'Clean'
command: rm -rf ./_build
- save_cache:
<<: *common_cache_key
paths:
- ~/.opam
- run:
name: 'Test'
command: |
eval `opam config env`
dune build @all
dune runtest --no-buffer
- when:
condition: <<parameters.all_tests>>
steps:
- run:
name: 'Test'
command: |
eval `opam config env`
dune build @all
dune runtest --no-buffer
- unless:
condition: <<parameters.all_tests>>
steps:
- run:
name: 'Test'
command: |
eval `opam config env`
dune build @async/all @lwt-unix/all @examples/lwt/all @examples/async/all
dune runtest --no-buffer
- run:
name: 'Check git is clean'
command: git diff --exit-code

jobs:
4.04.2:
OCaml-404:
docker:
- image: ocaml/opam2:debian-10-ocaml-4.04
environment:
- TERM: dumb
- OCAML_VERSION: "4.04.2"
- OPAMSOLVERTIMEOUT: "1200"
<<: *opam-steps
4.05.0:
OCaml-405:
docker:
- image: ocaml/opam2:debian-10-ocaml-4.05
environment:
- TERM: dumb
- OCAML_VERSION: "4.05.0"
- OPAMSOLVERTIMEOUT: "600"
<<: *opam-steps
4.06.1:
OCaml-406:
docker:
- image: ocaml/opam2:debian-10-ocaml-4.06
environment:
- TERM: dumb
- OCAML_VERSION: "4.06.1"
<<: *opam-steps
4.07.1:
OCaml-407:
docker:
- image: ocaml/opam2:debian-10-ocaml-4.07
environment:
- TERM: dumb
- OCAML_VERSION: "4.07.1"
<<: *opam-steps
4.08.1:
OCaml-408:
docker:
- image: ocaml/opam2:debian-10-ocaml-4.08
environment:
Expand All @@ -107,10 +125,8 @@ jobs:
- restore_cache:
<<: *esy_post_build_cache_key
- run:
name: "Install esy + system deps"
command: |
sudo apt-get install texinfo autotools-dev autoconf
npm install -g esy
name: "Install esy"
command: npm install -g esy
- run:
name: 'esy install'
command: ~/.npm-global/bin/esy install
Expand Down Expand Up @@ -138,27 +154,30 @@ workflows:
version: 2
build-deploy:
jobs:
- 4.04.2:
- OCaml-404:
all_tests: false
filters:
branches:
ignore:
- gh-pages
- 4.05.0:
- OCaml-405:
all_tests: false
filters:
branches:
ignore:
- gh-pages
- 4.06.1:
- OCaml-406:
all_tests: false
filters:
branches:
ignore:
- gh-pages
- 4.07.1:
- OCaml-407:
filters:
branches:
ignore:
- gh-pages
- 4.08.1:
- OCaml-408:
filters:
branches:
ignore:
Expand Down
3 changes: 3 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
Unreleased
--------------

- httpaf-mirage: depend on `mirage-conduit` instead of `conduit-mirage`,
effectively placing a lower bound of OCaml 4.07 on httpaf-mirage
([#16](https://github.com/anmonteiro/httpaf/pull/16))
- httpaf-lwt, httpaf-lwt-unix, httpaf-mirage: deduplicate interface code via a
common `Httpaf_lwt_intf` interface
([#13](https://github.com/anmonteiro/httpaf/pull/13))
Expand Down
4 changes: 2 additions & 2 deletions esy.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"@opam/faraday-async": "*",
"@opam/faraday-lwt-unix": "*",
"@opam/async": "*",
"@opam/mirage-conduit": "*",
"@opam/conduit-mirage": "*",
"@opam/lwt_ssl": "*",
"@opam/ssl": ">= 0.5.8"
},
Expand All @@ -23,6 +23,6 @@
"@opam/odoc": "*"
},
"resolutions": {
"@opam/conf-openssl": "esy-packages/esy-openssl#dafe9ad"
"@opam/conf-openssl": "esy-packages/esy-openssl#306bb87"
}
}
Loading