Fix NaN handling during validation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmolgupt
pushed a commit
that referenced
this pull request
Mar 23, 2023
* cache-aware streaming export Test onnx streaming conformer ctc WER Constant att cache width with len param Remove some extra functions in cache_aware runner transpose cache so that batch is first for trt Signed-off-by: Greg Clark <[email protected]> * fix export for full-context conformer * WIP trying to improve onnx perf Signed-off-by: Greg Clark <[email protected]> * Adding test scripts Signed-off-by: Greg Clark <[email protected]> * More perf testing script Signed-off-by: Greg Clark <[email protected]> * Updates for jit torch_tensorrt tracing Signed-off-by: Greg Clark <[email protected]> * Fixed trace warnings Signed-off-by: Boris Fomitchev <[email protected]> * Rearranging tests Signed-off-by: Boris Fomitchev <[email protected]> * Fixing non-caching case Signed-off-by: Boris Fomitchev <[email protected]> * testing Signed-off-by: Boris Fomitchev <[email protected]> * Fixed channel cache length issue Signed-off-by: Boris Fomitchev <[email protected]> * cache-aware streaming export Test onnx streaming conformer ctc WER Constant att cache width with len param Remove some extra functions in cache_aware runner transpose cache so that batch is first for trt Signed-off-by: Greg Clark <[email protected]> * fix export for full-context conformer * WIP trying to improve onnx perf Signed-off-by: Greg Clark <[email protected]> * Adding test scripts Signed-off-by: Greg Clark <[email protected]> * More perf testing script Signed-off-by: Greg Clark <[email protected]> * Updates for jit torch_tensorrt tracing Signed-off-by: Greg Clark <[email protected]> * stash Signed-off-by: Boris Fomitchev <[email protected]> * Reverting non-essential changes Signed-off-by: Boris Fomitchev <[email protected]> * Offset=None case Signed-off-by: Boris Fomitchev <[email protected]> * Remove test scripts Signed-off-by: Greg Clark <[email protected]> * Clean up speech_to_text_cache_aware_streaming_infer Signed-off-by: Greg Clark <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Revert pad -> constant_pad_nd Signed-off-by: Greg Clark <[email protected]> * conformer-encoder set window_size from streaming_cfg Signed-off-by: Greg Clark <[email protected]> * Fixes for working export(), using more constants Signed-off-by: Boris Fomitchev <[email protected]> * Optional rand init for cahce Signed-off-by: Greg Clark <[email protected]> * Folding update_cache with constants Signed-off-by: Boris Fomitchev <[email protected]> * More folding Signed-off-by: Boris Fomitchev <[email protected]> * Reducing diff #1 Signed-off-by: Boris Fomitchev <[email protected]> * Reducing diff #2 Signed-off-by: Boris Fomitchev <[email protected]> * Reducing diff #3 Signed-off-by: Boris Fomitchev <[email protected]> * Fixed unit tests, more reverts Signed-off-by: Boris Fomitchev <[email protected]> * Export fixes Signed-off-by: Boris Fomitchev <[email protected]> * Reverted slice changes that ruined ONNX perf Signed-off-by: Boris Fomitchev <[email protected]> * Adding back keep_all_outputs and drop_extra_preencoded Signed-off-by: Greg Clark <[email protected]> * Fix export Signed-off-by: Greg Clark <[email protected]> --------- Signed-off-by: Greg Clark <[email protected]> Signed-off-by: Boris Fomitchev <[email protected]> Co-authored-by: Boris Fomitchev <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Vahid Noroozi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information