Skip to content

Commit

Permalink
gha/macos-homebrew: Fix builds
Browse files Browse the repository at this point in the history
macOS 12 is deprecated for homebrew so bump to macOS 13.

Latest clang release requires linking with llvm unwind library
as C++ exceptions are not caught otherwise.
  • Loading branch information
anlambert committed Oct 19, 2024
1 parent 9ef65fd commit adb682b
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/macos-homebrew-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ jobs:
fail-fast: false
matrix:
config:
- name: Talipot build on macOS 12 (x86_64)
os: macos-12
- name: Talipot build on macOS 13 (x86_64)
os: macos-13
pyver: "3.12"
homebrew_path: /usr/local
- name: Talipot build on macOS 14 (arm64)
Expand Down Expand Up @@ -41,7 +41,7 @@ jobs:
fribidi
fontconfig
qt6
quazip || brew link --overwrite python@${{ matrix.config.pyver }}
quazip
- name: Install SIP
run: pip${{ matrix.config.pyver }} install sip --break-system-packages
- name: Prepare ccache timestamp
Expand All @@ -66,9 +66,11 @@ jobs:
-DCMAKE_C_COMPILER=${{ matrix.config.homebrew_path }}/opt/llvm/bin/clang
-DCMAKE_CXX_COMPILER=${{ matrix.config.homebrew_path }}/opt/llvm/bin/clang++
-DCMAKE_SHARED_LINKER_FLAGS="-L${{ matrix.config.homebrew_path }}/opt/llvm/lib/c++
-Wl,-rpath,${{ matrix.config.homebrew_path }}/opt/llvm/lib/c++"
-Wl,-rpath,${{ matrix.config.homebrew_path }}/opt/llvm/lib/c++
-L${{ matrix.config.homebrew_path }}/opt/llvm/lib/unwind -lunwind"
-DCMAKE_EXE_LINKER_FLAGS="-L${{ matrix.config.homebrew_path }}/opt/llvm/lib/c++
-Wl,-rpath,${{ matrix.config.homebrew_path }}/opt/llvm/lib/c++"
-Wl,-rpath,${{ matrix.config.homebrew_path }}/opt/llvm/lib/c++
-L${{ matrix.config.homebrew_path }}/opt/llvm/lib/unwind -lunwind"
-DCMAKE_RANLIB=/usr/bin/ranlib
-DPython3_EXECUTABLE=${{ matrix.config.homebrew_path }}/bin/python${{ matrix.config.pyver }}
-DTALIPOT_BUILD_CORE_ONLY=ON
Expand Down

0 comments on commit adb682b

Please sign in to comment.