talipot-gui/GlWidget: Fix segfault when not embeded in a graphics item

anlambert · Nov 23, 2023 · 0706a36 · 0706a36
1 parent 647d8fb
commit 0706a36
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/library/talipot-gui/include/talipot/GlWidget.h b/library/talipot-gui/include/talipot/GlWidget.h
@@ -286,7 +286,11 @@ class TLP_QT_SCOPE GlWidget : public QOpenGLWidget {
   // devicePixelRatio() must be overridden because the inherited QWidget
   // method always returns 1 when the widget is no attached to a window
   qreal devicePixelRatio() const {
-    return _windows->devicePixelRatio();
+    if (_windows) {
+      return _windows->devicePixelRatio();
+    } else {
+      return QOpenGLWidget::devicePixelRatio();
+    }
   }
 
 private:

diff --git a/library/talipot-gui/src/GlWidget.cpp b/library/talipot-gui/src/GlWidget.cpp
@@ -69,7 +69,7 @@ GlWidget::GlWidget(QWidget *parent, View *view)
   // windows attached to it, making device pixel ratio value unreliable so we
   // grab a pointer to the adequate main window to override the implementation
   // of the devicePixelRatio method
-  _windows = window()->windowHandle() ? window() : getMainWindow();
+  _windows = window()->windowHandle() ? nullptr : getMainWindow();
 }
 //==================================================
 GlWidget::~GlWidget() {