Sort FSRSItems by RevlogId for training #3660
Open
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to my recent benchmarking result, recency weighting could improve FSRS-5 ~4.8% relatively. This enhancement is comparable to the improvements seen in FSRS-5 over FSRS-4.5, or FSRS-4.5 over FSRS v4.
It requires a minor change in Anki's side: the items for training should be sorted in chronological order.
Of course, I can expose the weight assigning in the API, but it will introduce breaking changes and make the interface too complicated.
Relative PR: