Fix FSRS easy interval being same as good interval in relearning cards #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@L-M-Sherlock, please review the PR. |
|
Reason for second commit: |
|
The code is now future-proof. In FSRS v5, this code will prevent the fuzz from causing the Easy interval to become equal to or less than the Good interval (when the non-fuzzed intervals are close enough). |
L-M-Sherlock
approved these changes
Jun 26, 2024
user1823
commented
Jun 26, 2024
With a maximum interval set, it would be possible to confuse with_review_fuzz() by passing min > max.
|
Thank you both! |
user1823
commented
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3236 (comment)
Before #3236, the Easy interval for relearning cards was Good interval + 1. This PR restores that behaviour.
This is intended to be a temporary change. When FSRS will consider short-term reviews (in V5), the Easy interval will automatically become larger than the Good interval.