Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add APIs for IO card rendering #2739
Add APIs for IO card rendering #2739
Changes from all commits
48d86ba
e90ba8b
fb4fd60
1270ae1
39b36c1
86ddc41
bd06068
93fa113
a3f7ad8
eec7a4e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some people consider this an anti-pattern, and I've started to feel the same way. I know we have other examples in the codebase already that do this, but I'd suggest going forward, we limit this to public API exports, and avoid making these for our own use.
https://marvinh.dev/blog/speeding-up-javascript-ecosystem-part-7/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can definitely see that. I would also agree that the convenience factor in internal use really isn't that high.
However, given that third-party code consuming these APIs will likely also want to have access to their corresponding types, I'm wondering how we should best handle this here.
E.g., with the current state I can just import the various
Shape
types from this barrel file without having to worry about the internal structure of theshapes
package (annotating shape types with e.g.typeof globalThis.anki.imageOcclusion.Shape
doesn't work without some major TS acrobatics which are likely a bad practice of their own).Perhaps just bundling type exports in barrel files like these could be an option? Or splitting out type exports in a different way like d.ts files?
FWIW, I don't feel particularly strong about this from a stylistic standpoint, just want to make sure that we go with as defensive a solution as possible, so that using
anki
types is not too brittle long-term.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're consuming the types then it's arguably public API, and I remove my objection.
I'd like to return to the question of the best way to expose these to add-on authors in the future - some previous discussion about it can be found at #1764.