apiVersioning and developerContact implementation for AndkiDroid functions call from WebView #6377

krmanik · 2020-06-06T05:48:27Z

Pull Request template

Purpose / Description

This is implementation for api versioning for usage of AnkiDroid native functions in WebView.

Fixes

Approach

Getting api version & developer contact from card developer, then allow them to call the above functions implementation.

How Has This Been Tested?

Tested on Emulator
Calling this function before calling #6307 implemented functions

<script>
   AnkiDroidJS.init(ankiJSapiVersion, ankiDeveloperContact)
</script>

as

AnkiDroidJS.init("1.0.0", "dev1")

Learning (optional, can help others)

https://stackoverflow.com/questions/51513715/node-js-rest-api-versioning-the-right-way
https://stackoverflow.com/questions/32228300/how-to-prevent-my-snackbar-text-from-being-truncated-on-android

Checklist

Please, go through these checks before submitting the PR.

[ x ] You have not changed whitespace unnecessarily (it makes diffs hard to read)
[ x ] You have a descriptive commit message with a short title (first line, max 50 chars).
[ x ] Your code follows the style of the project (e.g. never omit braces in if statements)
[ x ] You have commented your code, particularly in hard-to-understand areas
[ x ] You have performed a self-review of your own code

Updated AbstractFlashcardViewer.java Updated AbstractFlashcardViewer.java Updated AbstractFlashcardViewer.java & Card.js

krmanik · 2020-06-06T05:49:36Z

I have just implement it to know that am I on right track for this implementation?

krmanik · 2020-06-06T12:10:33Z

As I understand the api versioning but for implementation part I need starting point.

mikehardy · 2020-06-09T18:42:02Z

tagging this up for review of the design - thanks for putting this up @infinyte7 ! @david-allison-1 this is a PR (that I haven't looked at yet, sorry) for the API management stuff we were batting around

mikehardy · 2020-06-11T17:11:19Z

This looks like what I was thinking for javascript developers to call to register, and then we'll have the processed values in Java to do what "seems right"

Then the following bits from the related issue where

inject a warning in review below the reviewer minibar / top of card if any parts of the interface were used with either no init or a deprecated API, including a link to a wiki page for more info - bonus points if it is dismissable for the entirety of a review session

a wiki page explaining that we're adding to the interface and need to be able to version it to manage change over time, plus the exact changes (ideally copy-pastable for users) to get rid of the warning

So I think next step is

abstracting the tentative / design review && "1.0.0".equals(apiVersion)) to something like a requireApiVersion("1.0.0") and
that requireApiVersion method should decompose major/minor/patch to make sure that current API version (sJsApiVersion = "1.0.0" ?) is at or above it

Here's where I'd just go for a side effect where we maybe also have a toggle (mJsApiCorrect ?) and if the card either has not registered or registered with an API we deem insufficient (maybe they are behind?) we inject a chunk of javascript that displays the API warning on top with a link to the wiki and developer contact (if the developer contact exists)

Please note that I am almost just thinking out loud here - this is like the brainstorming phase of design for the feature for me. I might be missing something obvious that you or anyone else sees, or there may be a much easier way to accomplish my real goal (which is for users to know when the Javascript on their cards might be broken, and if it was written by someone else, who and where to go for help, so they don't log issues here)

So any thoughts or completely different designs are welcome, as long as they meet that goal

krmanik · 2020-06-11T18:06:18Z

I understand the things but according to current knowledge it seems challenging but want to implement it so that I can learn more about this.

I will update this PR with above idea.
Thank you @mikehardy

mikehardy · 2020-06-11T18:09:58Z

Sure thing! And the learning is the fun part :-), I don't consider this blocking for your other stuff either, I appreciate that you're giving it a go in parallel. Cheers

krmanik · 2020-06-12T08:00:28Z

It work as expected.

Using deprecate api without develper contact.

Using deprecate api with develper contact.

david-allison

Likely on the side of overengineering here (@mikehardy - could do with guidance), but I hope this API gets long-term usage.

This approach doesn't allow a developer a capability-based approach. A developer can't currently know that their desired features are not supported and take corrective action.

I think the above approach will come in handy later on. I specifically will not want to allow my cards to toggle the navigation drawer, or perform "delete note" (for example), and it'd be nice for the developer to know that I've disabled the functionality, even if they choose to ignore the fact and call the API anyway.

david-allison · 2020-06-12T09:13:29Z

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

@@ -185,6 +186,11 @@
    // ETA
    private int eta;

+    // JavaScript Versioning
+    protected String apiVersion = "";


Could this follow the naming standards

Suggested change

protected String apiVersion = "";

protected String mCardSuppliedApiVersion = "";

david-allison · 2020-06-12T09:14:27Z

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

@@ -185,6 +186,11 @@
    // ETA
    private int eta;

+    // JavaScript Versioning
+    protected String apiVersion = "";
+    protected String developerContact = "";


These variables aren't reset between cards, this could theoretically show a previous developer's contact

david-allison · 2020-06-12T09:14:58Z

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

+    private void showDeveloperContact() {
+        View parentLayout = findViewById(android.R.id.content);
+        String snackbarMsg;
+        if (developerContact.equals("")) {


Needs to handle the user supplying null here

Suggested change

if (developerContact.equals("")) {

if (TextUtils.isEmpty(developerContact)) {

david-allison · 2020-06-12T09:15:34Z

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

+
+        Snackbar snackbar = Snackbar.make(parentLayout, snackbarMsg, 5000);
+        View snackbarView = snackbar.getView();
+        TextView snackTextView = (TextView) snackbarView.findViewById(com.google.android.material.R.id.snackbar_text);


I believe there are auto-linting suggestions here that will let you remove (TextView)

Suggested change

TextView snackTextView = (TextView) snackbarView.findViewById(com.google.android.material.R.id.snackbar_text);

TextView snackTextView = (TextView) snackbarView.findViewById(com.google.android.material.R.id.snackbar_text);

david-allison · 2020-06-12T09:16:43Z

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

+        snackTextView.setMaxLines(3);
+
+        snackbar.setActionTextColor(Color.MAGENTA)
+                .setAction("VIEW", view -> {


This will fail if the user does not have a browser. See AnkiActivity.openUrl

david-allison · 2020-06-12T09:23:32Z

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

+        snackTextView.setMaxLines(3);
+
+        snackbar.setActionTextColor(Color.MAGENTA)
+                .setAction("VIEW", view -> {


Needs to be extracted to a translatable string constant. Maybe rename to View Wiki.

Does snackbar auto-capitalise this text? showSimpleSnackBar will, and will make it easier for translators to get it right.

david-allison · 2020-06-12T09:24:21Z

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

@@ -3092,6 +3098,9 @@ private boolean filterUrl(String url) {
            }
            // flag card (blue, green, orange, red) using javascript from AnkiDroid webview
            if (url.startsWith("signal:flag_")) {
+                if (!requireApiVersion(apiVersion)) {


We'll need to decide which APIs are currently unstable.

david-allison · 2020-06-12T09:28:10Z

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

@@ -185,6 +186,11 @@
    // ETA
    private int eta;

+    // JavaScript Versioning
+    protected String apiVersion = "";
+    protected String developerContact = "";


Suggested change

protected String developerContact = "";

protected String mCardSuppliedDeveloperContact = "";

david-allison · 2020-06-12T09:30:06Z

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

+            snackbarMsg = getString(R.string.api_version_developer_contact, developerContact);
+        }
+
+        Snackbar snackbar = Snackbar.make(parentLayout, snackbarMsg, 5000);


Could you extract the constant (presumably the display time). Would it be possible to use LENGTH_LONG (2750ms), or is this too short?

david-allison · 2020-06-12T09:40:31Z

AnkiDroid/src/main/res/values/02-strings.xml

@@ -261,4 +261,7 @@
    <string name="restore_default">Restore Default</string>

    <string name="reviewer_tts_cloze_spoken_replacement">Blank</string>
+
+    <string name="api_version_developer_contact">Using uninitialized or deprecated JS api. Contact developer at %s, or view wiki to resolve this.</string>


Suggested change

<string name="api_version_developer_contact">Using uninitialized or deprecated JS api. Contact developer at %s, or view wiki to resolve this.</string>

<string name="api_version_developer_contact">This card uses unsupported AnkiDroid features. Contact the deck creator at %s, or view the wiki to resolve this manually.</string>

mikehardy · 2020-06-12T09:49:52Z

This approach doesn't allow a developer a capability-based approach. A developer can't currently know that their desired features are not supported and take corrective action.

I think the above approach will come in handy later on. I specifically will not want to allow my cards to toggle the navigation drawer, or perform "delete note" (for example), and it'd be nice for the developer to know that I've disabled the functionality, even if they choose to ignore the fact and call the API anyway.

Okay, so what exactly would that look like? spell out the actual methods and arguments and we can see what it looks like. I like the idea, as it might be nice to only allow (for instance) read-only APIs by default and for a developer to be able to handle that

david-allison · 2020-06-12T10:21:06Z

This approach doesn't allow a developer a capability-based approach. A developer can't currently know that their desired features are not supported and take corrective action.
I think the above approach will come in handy later on. I specifically will not want to allow my cards to toggle the navigation drawer, or perform "delete note" (for example), and it'd be nice for the developer to know that I've disabled the functionality, even if they choose to ignore the fact and call the API anyway.

Okay, so what exactly would that look like? spell out the actual methods and arguments and we can see what it looks like. I like the idea, as it might be nice to only allow (for instance) read-only APIs by default and for a developer to be able to handle that

Add another parameter/add a field to the object passed to init with a list of strings ['markCard', 'deleteNote', 'microphone']
Return a map of the same size with results:
- ['markCard'] = "allowed"
- ['deleteNote'] = "unavailable"
- //['microphone'] = "requiresPermission" - future use
The same, but single-parameter. Constant name

Multiple methods raise an API versioning issue.

Caller can ignore the result.

Current (slight) concerns:

is this overengineering?
Mix of permissions/versioning concerns.

krmanik · 2020-06-12T13:08:09Z

Getting information about api version and developer contact and pass all available functions status in one go.

I have implemented that.
My way is that pass developer contact and api version.
If api version match the mCurrentCardJsApiVersion then pass all the enabled/disabled functions.

If card have button to call ankiToggleFlag("red"); and supplied the incorrect / empty api version then nothing will happen, then deck developer can find all status regarding current api implementaion using following.

<script>
var jsApi = { "version" : "1.0.0", "developer" : "[email protected]" }
var apiData = AnkiDroidJS.init(JSON.stringify(jsApi));

// Return string 
var apiStatus = JSON.parse(apiData);

console.log("available api : " + apiStatus);

console.log(apiStatus["toggleFlag"]);  
console.log(apiStatus["markCard"]);
</script>

It will easy if we pass data in one go for all available functions.
Becase iterating for markCard, toggleFlag, microphone, then assigning enabled/disabled or true/false, make reviewing cards a little bit slow.

When api 1.0.0 passed

When api 2.0.0 passed

Updated apiVersioning Updated AbstractFlashcardViewer.java api enabled/disabled status Updated AbstractFlashcardViewer.java Updated AbstractFlashcardViewer.java api enabled/disabled status Updated apiVersioning

…droid into feature-branch

mikehardy · 2020-06-12T17:42:22Z

@david-allison-1 what do you think? I do see this mixing "versioning" and "capabilities" but since it's grouped within a well-named (IMHO) 'init' method I think having "the things we care about" (which is currently versioning and capabilities) in there isn't mixing, it's just where you would put them. So I don't think of it as mixing and don't mind.

I like how the version number the JS expects is simply declarative, so on the AnkiDroid side we can do API version progression (planned deprecation, removal) but we can also warn if the JS expects a version that is higher and tell users they need to upgrade AnkiDroid to use the full features of the card.

I'll review the actual implementation in a bit but wanted to flag David to check the current API shape since he proposed capabilities

Many thanks @infinyte7 for actually test-driving the ideas in an implementation we can see as we design it on the fly, I appreciate that as there is nothing like seeing it in action and having someone (you in this case) tell us how it feels

david-allison

Looks good to me! minor nitpicks and good to go!

@infinyte7 thanks so much for getting this in! Do you have any comments on the implementation, or is there anything here that could make your life easier?

@mikehardy Thanks for the guidance, as always

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

david-allison · 2020-06-12T17:49:54Z

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

+    private void showDeveloperContact() {
+        View parentLayout = findViewById(android.R.id.content);
+        String snackbarMsg;
+        if (TextUtils.isEmpty(mCardSuppliedDeveloperContact )) {


Suggested change

if (TextUtils.isEmpty(mCardSuppliedDeveloperContact )) {

if (TextUtils.isEmpty(mCardSuppliedDeveloperContact)) {

david-allison · 2020-06-12T17:50:43Z

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

+            JSONObject enabledJsApi = new JSONObject();
+
+            JSONObject data = new JSONObject(jsonData);
+            mCardSuppliedApiVersion = data.getString("version");


Let the user pass invalid data without a crash

Suggested change

mCardSuppliedApiVersion = data.getString("version");

mCardSuppliedApiVersion = data.optString("version", "");

david-allison · 2020-06-12T17:51:08Z

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

+        public String init(String jsonData) {
+            JSONObject enabledJsApi = new JSONObject();
+
+            JSONObject data = new JSONObject(jsonData);


Need to try.. catch here, just in-case the user provides bad input

david-allison · 2020-06-12T17:51:28Z

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

+            mCardSuppliedApiVersion = data.getString("version");
+            mCardSuppliedDeveloperContact  = data.getString("developer");
+
+            if (TextUtils.isEmpty(mCardSuppliedApiVersion) && TextUtils.isEmpty(mCardSuppliedDeveloperContact )) {


Suggested change

if (TextUtils.isEmpty(mCardSuppliedApiVersion) && TextUtils.isEmpty(mCardSuppliedDeveloperContact )) {

if (TextUtils.isEmpty(mCardSuppliedApiVersion) && TextUtils.isEmpty(mCardSuppliedDeveloperContact)) {

david-allison · 2020-06-12T17:53:39Z

AnkiDroid/src/main/res/values/01-core.xml

@@ -179,4 +179,6 @@
    <string name="read_write_permission_description">access existing notes, cards, note types, and decks, as well as create new ones</string>
    <string name="card_browser_label">Card Browser</string>
    <string name="card_browser_context_menu">Card Browser</string>
+
+    <string name="view">View</string>


Could you rename view to something that will help translators pick the correct phrase: reviewer_invalid_api_version_visit_documentation.

krmanik · 2020-06-13T05:24:21Z

I have updated suggested changes.

mikehardy · 2020-06-13T23:37:58Z

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

+            if (TextUtils.isEmpty(mCardSuppliedApiVersion) && TextUtils.isEmpty(mCardSuppliedDeveloperContact)) {
+                enabledJsApi.put("toggleFlag", "disabled");
+                enabledJsApi.put("markCard", "disabled");
+            } else if (requireApiVersion(mCardSuppliedApiVersion)) {
+                enabledJsApi.put("toggleFlag", "enabled");
+                enabledJsApi.put("markCard", "enabled");
+            } else {
+                enabledJsApi.put("toggleFlag", "disabled");
+                enabledJsApi.put("markCard", "disabled");
+            }


I think this chunk can be cleaner.
I think we will need an array of API strings, so that should be pulled out.
Then there should be a function that returns a map of all API functions, set to disabled.
You can call that function here to get a 'default off' map, then in here (where we are theoretically verifying API version compatibility and permission) you can check the API parameter then iterate and turn them on

So instead of a 3-part boolean test there is just a "default off" pre-init, a quick / short-circuit return if parameters are bad, then an iteration where you toggle on the APIs

I used hashmap, so that one time initialization done. At signal:url, checking the hashmap value, when true then available, false unavailable.
One time call of requireApiVersion function in init.

May be more better way for this.

mikehardy · 2020-06-13T23:47:02Z

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

+    private boolean requireApiVersion(String apiVer) {
+        return apiVer.equals(sCurrentJsApiVersion);
+    }


This mechanism needs some work I think, because it needs to take apart the semantic version and compare the fields numerically. This looks like a reasonable way to get semantic version info parsed out and comparable without any fuss https://github.com/AntiLaby/jsemver

We need to handle a few things with regard to versions though:
1- if the template JS for some reason needs a newer version than we support, we need to toast that
1- if the template JS calls an API we do implement, but that we are deprecating, we need to toast that (so we need the notion of deprecation somewhere, per-API?)

Maybe other stuff, try to think through an API lifecycle (AnkiDroid creating a new API and bumping version, deprecating an API, removing an API)

I have implemented it but need more improvement.

This is https://github.com/AntiLaby/jsemver nice. But may it will be helpful large project.
I use that idea and implemented in requireApiVersion.

david-allison

Mostly stylistic suggestions, will need to give this a final look

david-allison · 2020-06-14T12:53:21Z

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

@@ -53,6 +53,7 @@
 import android.text.SpannedString;
 import android.text.TextUtils;
 import android.text.style.UnderlineSpan;
+import android.util.Log;


I don't think this is used?

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

david-allison

Will need the merge in the history removed (or squashed out when merged into master)

krmanik · 2020-06-15T02:59:05Z

I have updated it.

krmanik · 2020-06-15T15:04:44Z

Is there any improvements needed to be done in this PR?

david-allison · 2020-06-15T15:47:05Z

@infinyte7 This still has merges in the commit history and can't be rebased onto the current master due to conflicts.

krmanik · 2020-06-15T16:26:26Z

So, should I rebase my github repo?

krmanik · 2020-06-20T15:01:30Z

Conflicts are in this PR.

This reverts commit f5fc7c1, reversing changes made to a52795b.

mikehardy · 2020-06-20T17:02:56Z

Something about the git commands you are using is not working at all
the sequence is typically git fetch upstream && git rebase upstream/master then resolve conflicts, assuming you have done git remote add upstream [email protected]:ankidroid/Anki-Android.git

There should never be a merge by this projects convention - and we appear to have lost the java changes from AbstractFlashcardViewer.java 😢

mikehardy · 2020-06-20T17:03:20Z

Android Studio does a pretty good job of saving "local history" so the files might be retrievable

krmanik · 2020-06-21T02:23:15Z

Thank you, I will create a clean separate PR after updating forked repo.

Updated card.js

6575387

Updated AbstractFlashcardViewer.java Updated AbstractFlashcardViewer.java Updated AbstractFlashcardViewer.java & Card.js

krmanik marked this pull request as draft June 8, 2020 16:14

mikehardy added the Needs Review label Jun 9, 2020

mikehardy requested a review from david-allison June 9, 2020 18:41

mikehardy added the Needs Author Reply Waiting for a reply from the original author label Jun 11, 2020

krmanik and others added 2 commits June 12, 2020 11:32

Added snackbar AbstractFlashcardViewer.java

b639e40

Updated apiVersioning

c0cd20d

krmanik marked this pull request as ready for review June 12, 2020 08:19

david-allison requested changes Jun 12, 2020

View reviewed changes

Updated apiVersioning

c01b226

krmanik added 6 commits June 12, 2020 18:41

Updated AbstractFlashcardViewer.java

81ff7c2

api enabled/disabled status

c5d03c6

Updated AbstractFlashcardViewer.java

24b0d36

Updated AbstractFlashcardViewer.java

1c6df52

Updated apiVersioning

2973b80

Updated apiVersioning Updated AbstractFlashcardViewer.java api enabled/disabled status Updated AbstractFlashcardViewer.java Updated AbstractFlashcardViewer.java api enabled/disabled status Updated apiVersioning

Merge branch 'feature-branch' of https://github.com/infinyte7/Anki-An…

f25f3a0

…droid into feature-branch

mikehardy requested a review from david-allison June 12, 2020 17:42

david-allison reviewed Jun 12, 2020

View reviewed changes

Updated AbstractFlashcardViewer.java, 01-core.xml, 02-strings.xml

f945a7d

Updated

c241de4

mikehardy reviewed Jun 13, 2020

View reviewed changes

krmanik added 2 commits June 14, 2020 12:38

Updated AbstractFlashcardViewer.java, 02-strings.xml

93314e9

Merge branch 'master' into feature-branch

753a545

mikehardy removed the Needs Author Reply Waiting for a reply from the original author label Jun 14, 2020

mikehardy requested review from mikehardy and david-allison June 14, 2020 17:47

david-allison reviewed Jun 14, 2020

View reviewed changes

david-allison requested changes Jun 14, 2020

View reviewed changes

Updated AbstractFlashcardViewer.java

a52795b

krmanik and others added 2 commits June 20, 2020 21:09

Merge branch 'master' into feature-branch

f5fc7c1

Revert "Merge branch 'master' into feature-branch"

55d8cc2

This reverts commit f5fc7c1, reversing changes made to a52795b.

krmanik marked this pull request as draft June 20, 2020 15:53

krmanik force-pushed the feature-branch branch from 55d8cc2 to f35d708 Compare June 20, 2020 16:45

krmanik force-pushed the feature-branch branch 2 times, most recently from 9abceaf to 55d8cc2 Compare June 21, 2020 02:57

krmanik mentioned this pull request Jun 21, 2020

apiVersioning and developerContact implementation for AnkiDroid functions call from WebView #6521

Merged

krmanik closed this Jun 21, 2020

krmanik deleted the feature-branch branch June 26, 2020 07:05

mikehardy removed the Needs Review label Jul 5, 2020

	protected String apiVersion = "";
	protected String mCardSuppliedApiVersion = "";

	if (developerContact.equals("")) {
	if (TextUtils.isEmpty(developerContact)) {

	TextView snackTextView = (TextView) snackbarView.findViewById(com.google.android.material.R.id.snackbar_text);
	TextView snackTextView = (TextView) snackbarView.findViewById(com.google.android.material.R.id.snackbar_text);

	protected String developerContact = "";
	protected String mCardSuppliedDeveloperContact = "";

	<string name="api_version_developer_contact">Using uninitialized or deprecated JS api. Contact developer at %s, or view wiki to resolve this.</string>
	<string name="api_version_developer_contact">This card uses unsupported AnkiDroid features. Contact the deck creator at %s, or view the wiki to resolve this manually.</string>

	if (TextUtils.isEmpty(mCardSuppliedDeveloperContact )) {
	if (TextUtils.isEmpty(mCardSuppliedDeveloperContact)) {

	mCardSuppliedApiVersion = data.getString("version");
	mCardSuppliedApiVersion = data.optString("version", "");

	if (TextUtils.isEmpty(mCardSuppliedApiVersion) && TextUtils.isEmpty(mCardSuppliedDeveloperContact )) {
	if (TextUtils.isEmpty(mCardSuppliedApiVersion) && TextUtils.isEmpty(mCardSuppliedDeveloperContact)) {

apiVersioning and developerContact implementation for AndkiDroid functions call from WebView #6377

apiVersioning and developerContact implementation for AndkiDroid functions call from WebView #6377

Conversation

krmanik commented Jun 6, 2020 • edited Loading

Pull Request template

Purpose / Description

Fixes

Approach

How Has This Been Tested?

Learning (optional, can help others)

Checklist

krmanik commented Jun 6, 2020

krmanik commented Jun 6, 2020

mikehardy commented Jun 9, 2020

mikehardy commented Jun 11, 2020

krmanik commented Jun 11, 2020

mikehardy commented Jun 11, 2020

krmanik commented Jun 12, 2020 • edited Loading

david-allison left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikehardy commented Jun 12, 2020

david-allison commented Jun 12, 2020 • edited Loading

krmanik commented Jun 12, 2020 • edited Loading

mikehardy commented Jun 12, 2020

david-allison left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

david-allison Jun 12, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

krmanik commented Jun 13, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

david-allison left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

david-allison left a comment • edited Loading

Choose a reason for hiding this comment

krmanik commented Jun 15, 2020

krmanik commented Jun 15, 2020

david-allison commented Jun 15, 2020

krmanik commented Jun 15, 2020

krmanik commented Jun 20, 2020

mikehardy commented Jun 20, 2020

mikehardy commented Jun 20, 2020

krmanik commented Jun 21, 2020

krmanik commented Jun 6, 2020 •

edited

Loading

krmanik commented Jun 12, 2020 •

edited

Loading

david-allison left a comment •

edited

Loading

david-allison commented Jun 12, 2020 •

edited

Loading

krmanik commented Jun 12, 2020 •

edited

Loading

david-allison Jun 12, 2020 •

edited

Loading

david-allison left a comment •

edited

Loading