Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in Reviewer due to incorrect cast #4452

Merged
merged 1 commit into from
Oct 14, 2016

Conversation

timrae
Copy link
Member

@timrae timrae commented Oct 13, 2016

Fixes #4451

I have no idea why it was working before... The code assumes the parent of the flashcard layout is a relative layout, but it looks like I accidentally "optimized" out the "unnecessary" RelativeLayout for the total fullscreen mode.

@hssm
Copy link
Member

hssm commented Oct 14, 2016

Is this the right branch?

@timrae
Copy link
Member Author

timrae commented Oct 14, 2016

Sorry, old habits die hard. We can cherry pick in either direction though right?

@hssm
Copy link
Member

hssm commented Oct 14, 2016

Yes, as long as we aren't delaying the next release. I don't mind if the change is included as long as it doesn't add another week+.

@timrae
Copy link
Member Author

timrae commented Oct 14, 2016

Yeah sorry my life has been quite crazy recently, and I haven't had much
time to stay on top of this release. I def want to include this fix, I'll
try put out a final beta this weekend, and a final release after a day or
two of testing.

On 14 Oct. 2016 11:08, "Houssam Salem" [email protected] wrote:

Yes, as long as we aren't delaying the next release. I don't mind if the
change is included as long as it doesn't add another week+.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4452 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACsA4ienGUmEaEx7Xw093BwHX3ErOPuDks5qzuQhgaJpZM4KVfht
.

@timrae timrae merged commit 96d90e3 into ankidroid:hotfix-2.6.2 Oct 14, 2016
@timrae timrae deleted the fix-fullscreen-crash branch October 14, 2016 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants