Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check media dialog not dismissed by touch #17492

Closed
wants to merge 1 commit into from

Conversation

criticalAY
Copy link
Contributor

Purpose / Description

Dismisses the dialog in case dismiss interface is called i.e. clears the stack so that the dialog is not shown again

Fixes

How Has This Been Tested?

Tested on Google Emulator API35
Screen_recording_20241124_215823.webm

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@criticalAY

This comment was marked as resolved.

@criticalAY
Copy link
Contributor Author

Adding you as the reviewer David since you would better know the logic of the underlying method as mentioned on discord

@criticalAY
Copy link
Contributor Author

The PR that it took conflict from seems to resolve the issue

@criticalAY criticalAY closed this Nov 27, 2024
@david-allison
Copy link
Member

@criticalAY Could you confirm whether this is fixed?

@criticalAY
Copy link
Contributor Author

@david-allison this was fixed when you made adjustments to the code related to async dialog code, hence I closed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Check media dialog not cleared from stack
2 participants