Feat[Multimedia]: render svg using webview

[criticalAY]

Purpose / Description

Render SVG instead of showing a warning text.

Blocked by

• fix: keep the format of imported images and remove 1MB limit #17014

Fixes

• Fixes Display SVGs in the image import preview #17029

Approach

Use a webview to render an SVG in it

How Has This Been Tested?

Tested on OnePlus Nord CE:

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[github-actions]

Message to maintainers, this PR contains strings changes.

1. Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
2. Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.

Read more about updating strings on the wiki,

• localization-administration
• download-localized-strings

[BrayanDSO]

Looks GREAT to me

[BrayanDSO]

Question: does this work for other formats?

Because animated PNGs are static in the ImageView, but animated when the card is opened

[criticalAY]

Question: does this work for other formats?

No this method would require workarounds for different images, we can directly use webview to preview images

[BrayanDSO]

we can directly use webview to preview images

So, is it possible to use the WebView instead of an ImageView to preview all the images?

That should handle all the images that can be rendered in a flashcard

[mikehardy]

this does seem like a fantastic opportunity to have a single way to do things vs conditionals

what if all images went through the webview? can this PR be altered to do that?

also would be nice to move this along by removing the dependency blocker - I think that other PR is about ready to go so the first commit can drop here ?

[criticalAY]

I will update it to use webview then /will rebase once the blocker goes in /

[mikehardy]

this one is free / unblocked now 🥳

[mikehardy]

This is looking really good. Love the "use webview for all the things" direction if we're going to be using a WebView at all

Was testing this and took a crash here - granted, unlikely perhaps in the wild but on an emulator, boom

• add note (basic forward/reversed)
• click paperclip
• select gallery

10-12 12:58:40.367  4867  4867 D MultimediaImageFragment: MultimediaImageFragment:: Opening gallery
10-12 12:58:40.391   661   963 D CompatibilityChangeReporter: Compat change id reported: 182734110; UID 10193; state: ENABLED
10-12 12:58:40.392   509   608 D audioserver: FGS Logger Transaction failed
10-12 12:58:40.392   509   608 D audioserver: -129
10-12 12:58:40.399   661   963 I ActivityTaskManager: START u0 {act=android.intent.action.PICK dat=content://media/...} with LAUNCH_MULTIPLE from uid 10193 result code=-91
10-12 12:58:40.399  4867  4867 D AndroidRuntime: Shutting down VM
--------- beginning of crash
10-12 12:58:40.404  4867  4867 E AndroidRuntime: FATAL EXCEPTION: main
10-12 12:58:40.404  4867  4867 E AndroidRuntime: Process: com.ichi2.anki.debug, PID: 4867
10-12 12:58:40.404  4867  4867 E AndroidRuntime: android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.PICK dat=content://media/... }
10-12 12:58:40.404  4867  4867 E AndroidRuntime: 	at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:2239)
10-12 12:58:40.404  4867  4867 E AndroidRuntime: 	at android.app.Instrumentation.execStartActivity(Instrumentation.java:1878)
10-12 12:58:40.404  4867  4867 E AndroidRuntime: 	at android.app.Activity.startActivityForResult(Activity.java:5589)
10-12 12:58:40.404  4867  4867 E AndroidRuntime: 	at androidx.activity.ComponentActivity.startActivityForResult(ComponentActivity.kt:704)
10-12 12:58:40.404  4867  4867 E AndroidRuntime: 	at androidx.core.app.ActivityCompat.startActivityForResult(ActivityCompat.java:244)
10-12 12:58:40.404  4867  4867 E AndroidRuntime: 	at androidx.activity.ComponentActivity$activityResultRegistry$1.onLaunch(ComponentActivity.kt:225)
10-12 12:58:40.404  4867  4867 E AndroidRuntime: 	at androidx.activity.result.ActivityResultRegistry$register$2.launch(ActivityResultRegistry.kt:137)
10-12 12:58:40.404  4867  4867 E AndroidRuntime: 	at androidx.fragment.app.Fragment$10.launch(Fragment.java:3637)
10-12 12:58:40.404  4867  4867 E AndroidRuntime: 	at androidx.activity.result.ActivityResultLauncher.launch(ActivityResultLauncher.kt:37)
10-12 12:58:40.404  4867  4867 E AndroidRuntime: 	at com.ichi2.anki.multimedia.MultimediaImageFragment.openGallery(MultimediaImageFragment.kt:328)
10-12 12:58:40.404  4867  4867 E AndroidRuntime: 	at com.ichi2.anki.multimedia.MultimediaImageFragment.handleSelectedImageOptions(MultimediaImageFragment.kt:288)
10-12 12:58:40.404  4867  4867 E AndroidRuntime: 	at com.ichi2.anki.multimedia.MultimediaImageFragment.handleImageUri(MultimediaImageFragment.kt:280)
10-12 12:58:40.404  4867  4867 E AndroidRuntime: 	at com.ichi2.anki.multimedia.MultimediaImageFragment.onViewCreated(MultimediaImageFragment.kt:272)
10-12 12:58:40.404  4867  4867 E AndroidRuntime: 	at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:3152)

The "take photo, crop it, see it in the preview both times" case worked well though
I did not test the "unsupported image type" case or the actual SVG case (yet)

[criticalAY]

I did test it with svg, gif and normal pictures

[mikehardy]

This'll take a conflict when #17467 merges regardless (I know because I had to rebase this on on that one in order to test some of the pathways, like even proceeding past the "do you want to compress?" dialog)

[criticalAY]

@david-allison ping for re-review

[mikehardy]

possibly higher performance (using StringBuffer etc) to use existing util

Anki-Android/AnkiDroid/src/main/java/com/ichi2/anki/utils/ext/InputStream.kt

Line 30 in c601271

fun InputStream.convertToString(): String {

[mikehardy]

If we're going to handle the WebView choking on large (okay: extremely huge) files separately that's fine by me. It did not crash which was good

So I'm +1 on this with a mild preference to delegate stream handling to centralized methods, as suggested in comment

[david-allison]

I'd like to see Mike's change included

Mine are optional

Treat this as an approve when:

• Mike's change is implemented
• The change is tested

[criticalAY]

@mikehardy @david-allison Done!

[david-allison]

REALLY clean, cheers!

[david-allison]

• Updated strings from Crowdin 2024/12/05 23:05 #17565 Strings

[github-actions]

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

• localization-administration
• download-localized-strings

[github-actions]

Hi there @criticalAY! This is the OpenCollective Notice for PRs merged from 2024-12-01 through 2024-12-31

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

Important

PLEASE NOTE: The process was updated in August 2024. Re-read the Payment Process page if you have not already.

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!