Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): re-enable gradle build cache #16057

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

david-allison
Copy link
Member

Purpose / Description

We disabled the gradle cache due to corruption bugs:

The underlying bug was closed and we're on Gradle 8.7:


I'm going to close this issue now that Gradle 8.7 has been released with a fix.
Please let us know if you continue to experience this problem with Gradle 8.7.

https://redirect.github.com/gradle/actions/issues/47#issuecomment-2030308363

gradle-wrapper.properties shows distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip

Approach

Revert the above two commits

How Has This Been Tested?

YOLO (CI only)

Learning (optional, can help others)

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

The underlying bug was closed and we're on Gradle 8.7

----

> I'm going to close this issue now that Gradle 8.7 has been released with a fix.
> Please let us know if you continue to experience this problem with Gradle 8.7.

https://redirect.github.com/gradle/actions/issues/47#issuecomment-2030308363

gradle-wrapper.properties:

`distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip`

----

Commits disabling the cache:

* ankidroid@6768519
* ankidroid@5ad2157
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Read through the related PRs, thanks for posting up useful info to them, that was a loose end I really wanted to pursue as it seemed like a serious upstream issue. I'm following the one they left open to get a real fix for gradle 8.8

@mikehardy mikehardy added this pull request to the merge queue Apr 2, 2024
Merged via the queue into ankidroid:main with commit e7b894a Apr 2, 2024
10 checks passed
@github-actions github-actions bot added this to the 2.18 release milestone Apr 2, 2024
@david-allison david-allison deleted the enable-build-caching branch April 7, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants