Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deck Options: add unconditional 'back' confirmation #15503

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Deck Options: add unconditional 'back' confirmation #15503

merged 2 commits into from
Feb 15, 2024

Conversation

david-allison
Copy link
Member

@david-allison david-allison commented Feb 15, 2024 •
edited
Loading

Fixes

Approach

  • ⚠️ Add unconditional back confirmation, as we can't know if changes are made
  • Add functionality to save, to be implemented later

How Has This Been Tested?

Screenshot 2024-02-15 at 03 51 44 Screenshot 2024-02-15 at 03 51 55 Screenshot 2024-02-15 at 03 30 16

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison force-pushed the 14438-deck-options-back branch 2 times, most recently from 7537307 to eac9773 Compare February 15, 2024 03:58
@david-allison
Copy link
Member Author

This requires #15502 for the save button to be visible

@BrayanDSO

This comment was marked as resolved.

Sign in to view
@BrayanDSO
Copy link
Member

Have you assessed the work involved in getting the change status in Anki?

I feel that this is too hacky and I already predict the complains about but I didn't do any change. This goes from a lack of support (i.e. not showing a message when it would be nice to have one) to showing a possibly misdirecting one

@BrayanDSO
Copy link
Member

Also, this doesn't seem urgent to need a hack

@david-allison
Copy link
Member Author

david-allison commented Feb 15, 2024 •
edited
Loading

Save icon: happy to kill & will do so. We'll want to talk about a design for 2.18. I'll leave in the functionality as it'll be useful later

Back: this is a major point of frustration for myself & another user

We're not going to have time to get this fixed in the backend before 2.18 and it's much better to add a frustrating dialog than have users lose changes

  1. I currently have no Svelte experience (this needs to change and is a personal goal for 2.18)
  2. I'm wanting to get 2.17 released around the end of this week

@david-allison david-allison force-pushed the 14438-deck-options-back branch from eac9773 to 90fc02d Compare February 15, 2024 15:28
mikehardy
mikehardy approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this given David's defense. Your questions seem correct @BrayanDSO but given the defense from David and desire for 2.17 to go, is this good enough for now?

@mikehardy mikehardy requested a review from BrayanDSO February 15, 2024 17:20
@mikehardy mikehardy added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Feb 15, 2024
@david-allison
feat(deck-options): Add confirmation on back
adae78a 
"Close and lose current input"

Due to the nature of the WebView content, the save button was
not prominent

I regularly found myself pressing 'back' and wondering why changes were
not persisted

We should improve this to conditionally be shown if a user makes changes

Fixes 14438
@david-allison
chore(deck-options): add 'saveAndExit'
2441281 
To be used in future to fix accessibility

Fixes 14438
@david-allison david-allison force-pushed the 14438-deck-options-back branch from 90fc02d to 2441281 Compare February 15, 2024 18:45
@david-allison david-allison added Needs Author Reply Waiting for a reply from the original author and removed Needs Author Reply Waiting for a reply from the original author labels Feb 15, 2024
@BrayanDSO
Copy link
Member

is this good enough for now?

There isn't that much problem with it, I was just pushing for a more appropriate approach, but for now LGTM

@BrayanDSO BrayanDSO added this pull request to the merge queue Feb 15, 2024
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Feb 15, 2024
Merged via the queue into ankidroid:main with commit 00d4960 Feb 15, 2024
7 checks passed
@github-actions github-actions bot added this to the 2.17 release milestone Feb 15, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Feb 15, 2024
@david-allison david-allison changed the title Deck Options: add unconditional 'back' confirmation and duplicate save icon Deck Options: add unconditional 'back' confirmation Feb 18, 2024
@david-allison david-allison deleted the 14438-deck-options-back branch February 18, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukstbit lukstbit lukstbit left review comments

@BrayanDSO BrayanDSO BrayanDSO approved these changes

@mikehardy mikehardy mikehardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.17 release
Development

Successfully merging this pull request may close these issues.

Deck options: 'back' should only request confirmation if changes are made
4 participants
@david-allison @BrayanDSO @mikehardy @lukstbit