Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnkiWeb will require TLS1.2 moving forward #5623

Closed
dae opened this issue Nov 12, 2019 · 14 comments · Fixed by #5658
Closed

AnkiWeb will require TLS1.2 moving forward #5623

dae opened this issue Nov 12, 2019 · 14 comments · Fixed by #5658

Comments

@dae
Copy link
Contributor

dae commented Nov 12, 2019

Hi all,

A heads up that TLS1.2 will be required to access AnkiWeb from Jan 1 2020:
https://anki.tenderapp.com/discussions/announcements/136-sunsetting-anki-20-support

From a brief Google, this looks like it may impact devices running early Android 4.x releases. If you want to retain compatibility, the following page may help: https://ankushg.com/posts/tls-1.2-on-android/

@mikehardy
Copy link
Member

Thanks for the headsup! and Oh, how I have suffered with TLS1.2 support on Android 4.x. There are a few workarounds yeah

Likely related in this repo #3626

Possibly related but only if we clip Android API support up to Android 5 / API21. We still have thousands of users on API19 and I don't think we were contemplating moving up to API21 so likely won't be resolved #5223

I'm going to mark this is as high priority for us since the time is short

@mikehardy
Copy link
Member

Relevant link to likely implementation we will need, from link above: https://gist.github.com/ankushg/8c0c3144318b1c17abb228d6211ba996

Note that as a test you need a server that already forces TLS1.2. There is likely a way to do this locally but I will submit that simply using a temporary file via direct download from dropbox works in my experience: https://github.com/mikehardy/react-native-update-apk#version-json-example

@timrae
Copy link
Member

timrae commented Nov 13, 2019

Sounds like a lot of fun 😬🤯

@mikehardy
I'm traveling the next two weeks then moving back to NZ for a new job, so please email me directly if there's some urgent action I need to take.

@mikehardy
Copy link
Member

Will do - but should not be urgent action - safe travels @timrae

@dotancohen
Copy link

I should probably mention that I'm stuck on API 19 with my E-ink devices. Please don't bump to API 21. Please.

@dotancohen
Copy link

Googling around I see that there are in fact solutions to use TLS1.2 on Android 4.4 (API 19). For a working example of an app that supports TLS 1.2 on API 19, (Opera Mobile](https://ftp.opera.com/pub/opera/android/mobile/1210/). There are quite a few threads on the topic in developer forums as well.

@mikehardy
Copy link
Member

No worries @dotancohen I was not seriously contemplating moving to API21. I've implemented several TLS hacks before for the old APIs and still have an old device I test with as well - it should be possible to support it :-)

@dotancohen
Copy link

@mikehardy Thank you! Your work - and Damien and Tim and everybody else - is very very much appreciated.

@mikehardy
Copy link
Member

mikehardy commented Dec 12, 2019

First step done, and publishing the WIP/Draft version just in case #5658

The commit contains a link to the second phase of the transformation (switch to okhttp3 request/response style from OkApacheClient wrapper, enable TLS1.2 during client build), which will enable TLS1.2 for Android API<=21

@mikehardy
Copy link
Member

@dotancohen please test, if possible: #5658 (comment)

@dotancohen
Copy link

@mikehardy Thank you, I will test.

@dotancohen
Copy link

I can confirm that AnkiDroid-2.10alpha17-TLS12.parallel.E.apk syncs fine in both directions on an Android 4.4 (API 19) Barnes & Noble Nook Glow3 E-ink device. Thank you!

@mikehardy mikehardy mentioned this issue Dec 19, 2019
5 tasks
@dae
Copy link
Contributor Author

dae commented Dec 27, 2019

A heads up that the deadline on this was extended to Feb 1, so no need to rush out a release if it needs more testing.

@mikehardy
Copy link
Member

mikehardy commented Dec 28, 2019

Thanks @dae I think that will help as I won't be available for triage and any needed 2.10.1 until a few days after the new year. But we are close now at least and the deadline pressure was useful to get me moving at any rate. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants