Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:'NoneType' object is not subscriptable_41_ #83

Merged
merged 1 commit into from
Aug 15, 2021
Merged

fix:'NoneType' object is not subscriptable_41_ #83

merged 1 commit into from
Aug 15, 2021

Conversation

dobefore
Copy link
Contributor

@dobefore dobefore commented Apr 27, 2021

this PR may be inconsistent with previous version.
@wsgify
def call(self, req):
data = req.POST['data'].file.read()
data = self._decode_data(data, compression)

return value of grave in data is None
so coerce it to default value

@VikashKothary
Copy link
Member

Hi @dobefore, thanks for another great fix.

I just want to understand what you mean by "may be inconsistent with previous version".
Is this going to be a breaking changes for older versions of Anki Desktop?

@dobefore
Copy link
Contributor Author

@VikashKothary ,I'm Sorry not think about earlier support.
I've tested It's been working on 2.1.40,so it may work too before 2.1.40.
So I might say thing goes well before and after 2.1.40.
Would like you to approve it!

@VikashKothary
Copy link
Member

Let's merge it since it does seem to be a fix. But if there are backward compatibility issues then we can deal with it then.

Thanks you for your contribution.

@VikashKothary VikashKothary merged commit 07723e9 into ankicommunity:develop Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants