Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and run unittests #62

Merged
merged 10 commits into from
Dec 29, 2020
Merged

Fix and run unittests #62

merged 10 commits into from
Dec 29, 2020

Conversation

VikashKothary
Copy link
Member

@VikashKothary VikashKothary commented Dec 23, 2020

  • Add missing webtest dependency
  • Add ankisyncd package after it was renamed in the poetry file to anki-sync-server
  • Run lock.sh script to update requirements.txt files

@VikashKothary VikashKothary changed the title Add webtest dependency Fix and run unittests Dec 23, 2020
@samyak-jain
Copy link
Contributor

Looks good to me. Thanks for adding this. Couple of suggestions:

Fix the format for the default .env.example included in the repo. If someone doesn't want to include the optional variables, it would throw an error by default. Just adding an = sign would fix the problem.

ANKISYNCD_FULL_SYNC_MANAGER=
ANKISYNCD_SESSION_MANAGER=
ANKISYNCD_USER_MANAGER=
ANKISYNCD_COLLECTION_WRAPPER=

Also, you should add instructions to run the tests in the readme. Something like this

mv .config/.env.example .config/.env.local
make init
poetry run make tests

@VikashKothary
Copy link
Member Author

That's a good point. I'm made the changes as requested. Let me know what you think.

@samyak-jain
Copy link
Contributor

Looks good. Thanks for these changes!

@VikashKothary VikashKothary merged commit bd5f002 into develop Dec 29, 2020
@VikashKothary VikashKothary deleted the feature/run-unittests branch December 29, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants