Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe and apply full stop conventions #384

Merged
merged 4 commits into from
Feb 4, 2021

Conversation

aplaice
Copy link
Collaborator

@aplaice aplaice commented Feb 2, 2021

<extreme_pedantry>

They were mostly applied in all languages.

(Apart from Swedish.)

Fix #383.

</extreme_pedantry>

(It should probably wait until after the 4.1 release, just in case — it's highly unlikely to mess anything up, but one never knows.)

(Also, fix a typo (s/Italie/Italië/) and remove an unnecessary space.)
Copy link
Collaborator

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work finding all the missing full stops! 😁 Not as many as I thought, actually!

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@axelboc
Copy link
Collaborator

axelboc commented Feb 3, 2021

(It should probably wait until after the 4.1 release, just in case — it's highly unlikely to mess anything up, but one never knows.)

Yeah, you're right, not worth rebuilding/reuploading all the decks.

@axelboc
Copy link
Collaborator

axelboc commented Feb 3, 2021

Oh and thanks for updating the table of contents ! ❤️ 😄

@aplaice
Copy link
Collaborator Author

aplaice commented Feb 3, 2021

Thanks for the nitpicking! Nitpicking-guidelines deserve extra-thorough nitpicking! :)

I think that I've applied all your suggestions!

@axelboc axelboc merged commit c8bbf11 into anki-geo:master Feb 4, 2021
@axelboc axelboc added the content Content changes, map improvements, translation fixes, etc. label Apr 10, 2021
@axelboc axelboc added this to the v4.2 milestone Apr 10, 2021
@aplaice aplaice deleted the full_stop_contributing branch December 21, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes, map improvements, translation fixes, etc.
Development

Successfully merging this pull request may close these issues.

Use of full stops at the ends of descriptive fields
2 participants