Make maps of Balkans and Saint Helena consistent with main style #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing! ✨ |
axelboc
added
the
content
Closed
|
Culturally Vojvodina and Slavonia should be considered part of the Balkan Penninsula. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saint Helena's map could do with a zoom box, but I don't think it's essential since there are no other islands in the immediate vicinity, and Saint Helena's exact shape isn't that important.
The Balkan Peninsula map uses a slightly different choice of definition of the Balkans than the existing map, but I don't think it's a worse definition (our current map uses the Danube-Sava-Kupa line, while my map uses the Soča–Vipava–Krka–Sava–Danube line (which was what was in Natural Earth Data)). According to Wikipedia, "The northern border of the peninsula is variously defined.". (The definition used for the map in the infobox is the Danube–Sava–Soča one which is different yet...) In any case the differences are quite slight.
(See #1.)
Comparisons of the old and new maps
Balkans
Saint Helena