Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip signature check if base64PublicKey is null #68

Merged
merged 5 commits into from
Mar 3, 2015

Conversation

renedecandido
Copy link
Contributor

If the license key is NULL the signature check is skipped (as stated in the readme file "You can pass NULL if you would like to skip this check")

@vitas
Copy link

vitas commented Feb 26, 2015

without comment why that change is required, you should rather use TextUtils.isEmpty(publicKey) for consistency and remove such check below in if statement to clean it up

@renedecandido
Copy link
Contributor Author

As described in the library's README.md you can pass NULL instead of the License Key to skip the purchase signature verification. In case of a NULL License Key the library returned false and broke the normal purchase flow which is not desired in case you are checking the signature on a server.

@serggl
Copy link
Member

serggl commented Feb 26, 2015

this is a fair pull request. Just give me some time to merge it

On Thu, Feb 26, 2015 at 5:15 PM René De Candido [email protected]
wrote:

As described in the library's README.md you can pass NULL instead of the
License Key to skip the purchase signature verification. In case of a NULL
License Key the library returned false and broke the normal purchase flow
which is not desired in case you are checking the signature on a server.


Reply to this email directly or view it on GitHub
#68 (comment)
.

@serggl
Copy link
Member

serggl commented Feb 27, 2015

actually, I would like to move this check from Security.verifyPurchase to BillingProcessor.verifyPurchaseSignature method. And also this should be done with TextUtils.isEmpty like @vitas mentioned.

Would you mind to apply these changes?

serggl added a commit that referenced this pull request Mar 3, 2015
fix: skip signature check if base64PublicKey is null
@serggl serggl merged commit 8573e18 into anjlab:master Mar 3, 2015
showdpro pushed a commit to showdpro/android-inapp-billing-v3 that referenced this pull request Jul 13, 2021
fix: skip signature check if base64PublicKey is null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants