Support for GetPurchaseHistory #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isRequestBillingHistorySupported - to check if request purchase history supported getPurchaseHistory - to request purchase history
Closed
serggl
reviewed
Jul 22, 2019
| throw new RuntimeException("Unsupported type " + type); | ||
| } | ||
|
|
||
| IInAppBillingService billing = billingService; |
There was a problem hiding this comment.
do we really need a local var here?
There was a problem hiding this comment.
Yes, this.billingService becomes null if service disconnects. So it is possible to get NPE if method called in secondary thread.
serggl
reviewed
Jul 22, 2019
| @@ -489,6 +490,42 @@ public boolean isOneTimePurchaseWithExtraParamsSupported(Bundle extraParams) | |||
| return isOneTimePurchaseExtraParamsSupported; | |||
| } | |||
|
|
|||
| /** | |||
| * Checks does API support version 6 required to request purchase history | |||
There was a problem hiding this comment.
lets change this descripton to Checks if API supports version 6 which required to request purchase history.
I ❤️ the descriptions in this PR BTW
serggl
reviewed
Jul 22, 2019
serggl
reviewed
Jul 23, 2019
| @@ -238,6 +238,25 @@ public final Date purchaseTime; | |||
| public final PurchaseInfo purchaseInfo; | |||
| ``` | |||
|
|
|||
| ## Getting Purchase History | |||
|
@serggl Thank you for accepting & merging PR. Can we expect updated artifact soon? (1.0.46 I suppose) |
serggl
added a commit
that referenced
this pull request
Jul 23, 2019
|
1.1.0 was just deployed |
|
Good work yall |
showdpro
pushed a commit
to showdpro/android-inapp-billing-v3
that referenced
this pull request
Jul 13, 2021
* New API for BillingProcessor: isRequestBillingHistorySupported - to check if request purchase history supported getPurchaseHistory - to request purchase history * Updated code according to checkstyle * Updated README to cover new API with getPurchaseHistory.
showdpro
pushed a commit
to showdpro/android-inapp-billing-v3
that referenced
this pull request
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New API for BillingProcessor:
isRequestBillingHistorySupported - to check if request purchase history supported
getPurchaseHistory - to request purchase history