Support for getBuyIntentExtraParams() #287

ratm · 2017-07-18T09:49:57Z

This PR addresses issue #241, adding support for getBuyIntentExtraParams() as this is the recommended method by Google.
https://developer.android.com/google/play/billing/billing_reference.html#getBuyIntent

The method is a variant of the getBuyIntent() method, and takes an additional extraParams parameter.

More info here: https://developer.android.com/google/play/billing/billing_reference.html#getBuyIntentExtraParams

Add support for getBuyIntentExtraParams() as this is the recommended method by Google https://developer.android.com/google/play/billing/billing_reference.html#getBuyIntent The method is a variant of the getBuyIntent() method, and takes an additional extraParams parameter. More info here: https://developer.android.com/google/play/billing/billing_reference.html#getBuyIntentExtraParams

serggl · 2017-07-18T10:23:33Z

instead of adding a new parameter to existing function,lets just add another function

ratm · 2017-07-18T10:48:45Z

@serggl I'm not sure to understand your remark.
Could you elaborate? Thanks!

…ad of overriding existing ones

ratm · 2017-07-18T17:48:32Z

@serggl Please let me know if my changes properly addressed your feedback. Thanks!

serggl · 2017-07-19T11:42:28Z

library/src/main/java/com/anjlab/android/iab/v3/BillingProcessor.java

+	 * @return {@code false} if the billing system is not initialized, {@code productId} is empty
+	 * or if an exception occurs. Will return {@code true} otherwise.
+	 */
+	public boolean purchaseWithExtraParams(Activity activity, String productId, String developerPayload, Bundle extraParams)


lets name it also purchase for consistency

serggl · 2017-07-19T11:42:46Z

library/src/main/java/com/anjlab/android/iab/v3/BillingProcessor.java

+	 * @return {@code false} if the billing system is not initialized, {@code productId} is empty or if an exception occurs.
+	 * Will return {@code true} otherwise.
+	 */
+	public boolean subscribeWithExtraParams(Activity activity, String productId, String developerPayload, Bundle extraParams)


lets name it subscribe

serggl · 2017-07-19T11:43:35Z

library/src/main/java/com/anjlab/android/iab/v3/BillingProcessor.java

+	 * @return {@code false} if {@code oldProductIds} is not {@code null} AND change subscription
+	 * is not supported.
+	 */
+	public boolean updateSubscriptionWithExtraParams(Activity activity, List<String> oldProductIds,


lets name it updateSubscription

serggl · 2017-07-19T13:09:50Z

library/src/main/java/com/anjlab/android/iab/v3/BillingProcessor.java

-																 productId,
-																 purchaseType,
-																 purchasePayload);
+				int apiVersion = Constants.GOOGLE_API_EXTRA_PARAMS_SUPPORTED_VERSION;


Im worried that this API might not be supported, but same time v5 API (GOOGLE_API_SUBSCRIPTION_CHANGE_VERSION) may be. So its kind of a breaking change. We have isSubscriptionUpdateSupported() method that was checking if v5 API is supported, but we dont have one to check the availability of this newly introduced API.
So I guess there should be something in this method that checks for API version and uses backward compatible method if needed

serggl · 2017-07-19T13:11:56Z

library/src/main/java/com/anjlab/android/iab/v3/BillingProcessor.java

-													 productId,
-													 purchaseType,
-													 purchasePayload);
+				bundle = billingService.getBuyIntentExtraParams(Constants.GOOGLE_API_EXTRA_PARAMS_SUPPORTED_VERSION,


same here. if we change API version from v3 to v6 we must ensure we have a backward compatibility plan

Use isBillingSupportedExtraParams() to check if we can use the new getBuyIntentExtraParams() method and fallback to the previous method if that’s not the case. As isBillingSupportedExtraParams() is only available starting with Billing API v7, we effectively limit the usage of getBuyIntentExtraParams() to Billing API v7+

ratm · 2017-07-19T14:36:39Z

@serggl I'm now using isBillingSupportedExtraParams() to use the new API only if available.

serggl · 2017-07-20T15:05:54Z

library/src/main/java/com/anjlab/android/iab/v3/BillingProcessor.java

-													 productId,
-													 purchaseType,
-													 purchasePayload);
+				if( extraParamsBundle == null) // API v3


can we remove a leading whitespace here?

serggl · 2017-07-20T15:08:43Z

library/src/main/java/com/anjlab/android/iab/v3/Constants.java

@@ -19,6 +19,8 @@
 {
 	public static final int GOOGLE_API_VERSION = 3;
 	public static final int GOOGLE_API_SUBSCRIPTION_CHANGE_VERSION = 5;
+	public static final int GOOGLE_API_EXTRA_PARAMS_SUPPORTED_VERSION = 6;


seem like this constant is not used for right now

serggl · 2017-07-20T15:19:05Z

library/src/main/java/com/anjlab/android/iab/v3/BillingProcessor.java

@@ -364,6 +413,50 @@ public boolean isSubscriptionUpdateSupported()
 		return isSubsUpdateSupported;
 	}

+	public boolean isSubscriptionWithExtraParamsSupported(Bundle extraParams)


a little Javadoc here would be 👍

serggl · 2017-07-20T15:19:59Z

library/src/main/java/com/anjlab/android/iab/v3/BillingProcessor.java

+	 * is not supported.
+	 */
+	public boolean updateSubscription(Activity activity, List<String> oldProductIds,
+													 String productId, String developerPayload, Bundle extraParams)


argument list here seem to be off from the indentation

serggl · 2017-07-20T15:21:39Z

library/src/main/java/com/anjlab/android/iab/v3/BillingProcessor.java

-																 productId,
-																 purchaseType,
-																 purchasePayload);
+				if(extraParamsBundle == null) // API v3


Api v5 actually :)

serggl · 2017-07-21T06:20:43Z

This now looks good!
last thing I could think of is that the changes made should be somehow reflected in the README

serggl · 2017-07-22T06:59:17Z

Thank you 👍 Will release this early next week

ratm · 2017-07-22T11:16:07Z

Sounds great! Thank you @serggl!

@serggl

* Add support for getBuyIntentExtraParams() Add support for getBuyIntentExtraParams() as this is the recommended method by Google https://developer.android.com/google/play/billing/billing_reference.html#getBuyIntent The method is a variant of the getBuyIntent() method, and takes an additional extraParams parameter. More info here: https://developer.android.com/google/play/billing/billing_reference.html#getBuyIntentExtraParams * Cleanup * Address coding style issues * Remove extra blank line * As requested, create specific methods to send the extra params, instead of overriding existing ones * Fix style * Implement @serggl’s feedback Use isBillingSupportedExtraParams() to check if we can use the new getBuyIntentExtraParams() method and fallback to the previous method if that’s not the case. As isBillingSupportedExtraParams() is only available starting with Billing API v7, we effectively limit the usage of getBuyIntentExtraParams() to Billing API v7+ * Add missing javadoc + Fix style * Update README to add new methods usage

ratm added 4 commits July 18, 2017 11:46

Cleanup

23cf294

Address coding style issues

9968d88

Remove extra blank line

786d80c

ratm added 2 commits July 18, 2017 15:49

As requested, create specific methods to send the extra params, inste…

9d9149f

…ad of overriding existing ones

Fix style

b8d0a4b

serggl requested changes Jul 19, 2017

View reviewed changes

serggl reviewed Jul 20, 2017

View reviewed changes

Add missing javadoc + Fix style

45e1a20

Update README to add new methods usage

d4adbea

serggl approved these changes Jul 24, 2017

View reviewed changes

serggl merged commit c8e0cd8 into anjlab:master Jul 24, 2017

serggl added a commit that referenced this pull request Jul 24, 2017

bump build version to accomodate #287

8954265

showdpro pushed a commit to showdpro/android-inapp-billing-v3 that referenced this pull request Jul 13, 2021

bump build version to accomodate anjlab#287

f384e84

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for getBuyIntentExtraParams() #287

Support for getBuyIntentExtraParams() #287

ratm commented Jul 18, 2017

serggl commented Jul 18, 2017

ratm commented Jul 18, 2017

ratm commented Jul 18, 2017

serggl Jul 19, 2017

serggl Jul 19, 2017

serggl Jul 19, 2017

serggl Jul 19, 2017

serggl Jul 19, 2017

ratm commented Jul 19, 2017

serggl Jul 20, 2017

serggl Jul 20, 2017

serggl Jul 20, 2017

serggl Jul 20, 2017

serggl Jul 20, 2017

serggl commented Jul 21, 2017

serggl commented Jul 22, 2017

ratm commented Jul 22, 2017

Support for getBuyIntentExtraParams() #287

Support for getBuyIntentExtraParams() #287

Conversation

ratm commented Jul 18, 2017

serggl commented Jul 18, 2017

ratm commented Jul 18, 2017

ratm commented Jul 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ratm commented Jul 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

serggl commented Jul 21, 2017

serggl commented Jul 22, 2017

ratm commented Jul 22, 2017