Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getBuyIntentToReplaceSkus() support #142

Merged
merged 5 commits into from
Jan 24, 2016
Merged

getBuyIntentToReplaceSkus() support #142

merged 5 commits into from
Jan 24, 2016

Conversation

mzestars
Copy link

Update IInAppBillingService.aidl to latest from Google
Added code for to check if change subscription is supported
Added code for changing subscription

@mzestars mzestars changed the title Develop getBuyIntentToReplaceSkus() support Dec 29, 2015
oldProductIds = new ArrayList<>(1);
oldProductIds.add(oldProductId);
}
return updateSubscription(activity, oldProductIds, productId);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzestars maybe we should call here isSubscriptionUpdateSupported() method first?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serggl Sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzestars any update on this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serggl This is my first time contributing to open source project. So, I make the changes and make another pull request?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make a change to your branch and it will be automaticslly picked up by
the current PR

сб, 16 янв. 2016 г., 18:28, Mohd Zulfadhli Bin Ab Rashid <
[email protected]>:

In library/src/main/java/com/anjlab/android/iab/v3/BillingProcessor.java
#142 (comment)
:

  •   }
    
  •   return false;
    
  • }
  • /**
  • * Change subscription i.e. upgrade or downgrade
  • * @param oldProductId passing null or empty string will act the same as {@link #subscribe(Activity, String)}
  • */
  • public boolean updateSubscription(Activity activity, String oldProductId, String productId) {
  •   List<String> oldProductIds = null;
    
  •   if (!TextUtils.isEmpty(oldProductId)) {
    
  •       oldProductIds = new ArrayList<>(1);
    
  •       oldProductIds.add(oldProductId);
    
  •   }
    
  •   return updateSubscription(activity, oldProductIds, productId);
    

@serggl https://github.com/serggl This is my first time contributing to
open source project. So, I make the changes and make another pull request?


Reply to this email directly or view it on GitHub
https://github.com/anjlab/android-inapp-billing-v3/pull/142/files#r49932981
.

Sergey, AnjLab

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serggl Done.

@serggl serggl merged commit 75eb4b6 into anjlab:master Jan 24, 2016
@serggl
Copy link
Member

serggl commented Jan 24, 2016

thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants