-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 features added (see description) #108
Conversation
That's great thank you !!! but how does it work should I change my Code to use this? or is this prevention used automatically when I use the library ? |
bindPlayServices(); | ||
} | ||
|
||
public BillingProcessor(Context context, String licenseKey, String merchantId, IBillingHandler handler) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we re-use existing one constructor here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, you can use. I kept old constructor. If you will use old constructor no check against merchantId
will be provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mustii82 you have to provide your merchantId
to a new constructor and in case of attack you'll see it in onBillingError()
handler with special error code
@ivanovpv what is an merchantId? and where can i find it ? and I must just use the second constructor? can you make an example please |
|
@ivanovpv can you please update README file with instructions on how to use it? Having that, Im ok with merging this PR |
@serggl Sure, I will do it in a few days |
@serggl Done! Not sure whether to give link to Freedome? Or it's bad practice to advertise crackers... |
It doesn't matters if somebody want to prevent in app hacking attacks they can use this library :P but I think its better to name it a hacking prevention because freedom is the only working way to fake in app purchases. By the way there is an app called lucky patcher it can fake in app purchase too i heard but i don't know how it works so can you maybe test it ? |
can be found in your [Payments Merchant Account](https://payments.google.com/merchant). | ||
Selecting *Settings->Public Profile* you will find your unique `merchantId` | ||
|
||
**WARNING:** keep your `merchantId` in safe place! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean with keep your merchant ID safe? can somebody do damage to me if he know what my merchant ID is?
BillingProcessor.isIabServiceAvailable()
merchantId
extracted fromorderId
. Well-known method to protect against Freedom alike attacks