Use custom struct BufferWriter instaed of StringBuilder in IonReader #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization with better separation of concerns.
Main goal of this optimisation is to remove usage of StringBuilder used as intermediate buffer for line. The StringBuilder object was allocated and it allocated internal buffer for string. I changed it with light struct that writes data directly into rented char array that is exposed in CurrentRawLine. It also improves separation of concerns in IonReader.
The other changes:
[DoesNotReturn]
to ThrowHelper methods to improve nullable code analysis