Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Fix search event test by breaking it into 3 checks #749

Merged
merged 1 commit into from
Jun 27, 2018

Conversation

Monal5031
Copy link
Contributor

Description

search event consisted of 3 checks; both date present, only start, only end. Since for all those 3 checks we were clicking on the same link it created instability and raised StaleElementException. Thus we need to break it in 3 different tests.

Fixes #747

Type of Change:

  • Code
  • Quality Assurance

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

This was working fine locally but it creates issues on travis, so we need to check travis logs mainly. Otherwise local testing can be done using

python manage.py test event/ -v 2

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@Monal5031 Monal5031 added Priority: HIGH Type: Testing UI Tests, Integration Tests, Travis CI, etc. Program: GSOC Related to work completed during the Google Summer of Code Program. labels Jun 27, 2018
@anitab-org anitab-org deleted a comment Jun 27, 2018
Copy link
Contributor

@abarya abarya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit


sign_up_page = self.sign_up_page
sign_up_page.live_server_url = self.live_server_url

# Enter correct ending date
sign_up_page.go_to_sign_up_page()
date = ['', '06/15/2050']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line at the end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @abhishekarya286 Please review again.

@abarya
Copy link
Contributor

abarya commented Jun 27, 2018

Thanks @Monal5031. Just resolve this issue and I'll merge your PR

@anjali-dhanuka
Copy link
Contributor

@Monal5031 This issue is the reason for #722 build failure right?

@Monal5031
Copy link
Contributor Author

@anjali-dhanuka Yeah this test was unstable, I had restarted the build on your PR its now passing.

@abarya abarya merged commit 15a958c into anitab-org:gsoc18-infra Jun 27, 2018
@abarya
Copy link
Contributor

abarya commented Jun 27, 2018

Thank @Monal5031

@Monal5031 Monal5031 deleted the fix-search-event branch August 11, 2018 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Program: GSOC Related to work completed during the Google Summer of Code Program. Type: Testing UI Tests, Integration Tests, Travis CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants