This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Fix search event test by breaking it into 3 checks #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monal5031
added
Priority: HIGH
Type: Testing
UI Tests, Integration Tests, Travis CI, etc.
Program: GSOC
Related to work completed during the Google Summer of Code Program.
labels
Jun 27, 2018
Monal5031
requested review from
pavankm,
naman1901,
prachi1210,
anjali-dhanuka and
abarya
June 27, 2018 05:23
Monal5031
force-pushed
the
fix-search-event
branch
from
June 27, 2018 05:26
1e4903b
to
cc725a3
Compare
abarya
approved these changes
Jun 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor nit
|
||
sign_up_page = self.sign_up_page | ||
sign_up_page.live_server_url = self.live_server_url | ||
|
||
# Enter correct ending date | ||
sign_up_page.go_to_sign_up_page() | ||
date = ['', '06/15/2050'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done @abhishekarya286 Please review again.
Thanks @Monal5031. Just resolve this issue and I'll merge your PR |
Monal5031
force-pushed
the
fix-search-event
branch
from
June 27, 2018 09:00
cc725a3
to
43b9402
Compare
@Monal5031 This issue is the reason for #722 build failure right? |
@anjali-dhanuka Yeah this test was unstable, I had restarted the build on your PR its now passing. |
abarya
approved these changes
Jun 27, 2018
Thank @Monal5031 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Program: GSOC
Related to work completed during the Google Summer of Code Program.
Type: Testing
UI Tests, Integration Tests, Travis CI, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
search event consisted of 3 checks; both date present, only start, only end. Since for all those 3 checks we were clicking on the same link it created instability and raised StaleElementException. Thus we need to break it in 3 different tests.
Fixes #747
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
This was working fine locally but it creates issues on travis, so we need to check travis logs mainly. Otherwise local testing can be done using
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only