Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Testing Authentication app #719

Merged
merged 2 commits into from
Jul 15, 2018

Conversation

Monal5031
Copy link
Contributor

@Monal5031 Monal5031 commented Jun 7, 2018

Description

Tested Authentication app

  • Uncommented and corrected the commented tests

Closes #717

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

To verify that tests are non-breaking change in job app use:

python manage.py test authentication -v 2

and to overall project use:

python manage.py test

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • [x]I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@Monal5031 Monal5031 added Priority: HIGH Type: Testing UI Tests, Integration Tests, Travis CI, etc. Program: GSOC Related to work completed during the Google Summer of Code Program. labels Jun 7, 2018
@Monal5031 Monal5031 force-pushed the testing-authentication branch from 406d55a to e5b9f60 Compare June 7, 2018 10:46
@anitab-org anitab-org deleted a comment Jun 7, 2018
@anitab-org anitab-org deleted a comment Jun 7, 2018
@anitab-org anitab-org deleted a comment Jun 7, 2018
@anitab-org anitab-org deleted a comment Jun 7, 2018
@Monal5031
Copy link
Contributor Author

ping @anjali-dhanuka You need this first?

Copy link
Contributor

@anjali-dhanuka anjali-dhanuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naman1901
Copy link
Contributor

You're missing a few statements on forms (0% coverage) and views (85%). Overall coverage is great, just wanna know if there's a particular reason for this.

@Monal5031 Monal5031 force-pushed the testing-authentication branch from e5b9f60 to d400bb3 Compare June 10, 2018 04:43
@anitab-org anitab-org deleted a comment Jun 10, 2018
@anitab-org anitab-org deleted a comment Jun 10, 2018
@anitab-org anitab-org deleted a comment Jun 10, 2018
@anitab-org anitab-org deleted a comment from Monal5031 Jun 10, 2018
@anitab-org anitab-org deleted a comment from Monal5031 Jun 10, 2018
@anitab-org anitab-org deleted a comment from naman1901 Jun 10, 2018
@Monal5031 Monal5031 force-pushed the testing-authentication branch from d400bb3 to 630c475 Compare June 10, 2018 04:54
@anitab-org anitab-org deleted a comment Jun 10, 2018
@anitab-org anitab-org deleted a comment Jun 10, 2018
@Monal5031 Monal5031 force-pushed the testing-authentication branch from 630c475 to 767ff04 Compare June 10, 2018 05:05
@anitab-org anitab-org deleted a comment Jun 10, 2018
@anitab-org anitab-org deleted a comment Jun 10, 2018
@anitab-org anitab-org deleted a comment Jun 24, 2018
@anitab-org anitab-org deleted a comment Jun 24, 2018
@anitab-org anitab-org deleted a comment Jun 24, 2018
@Monal5031 Monal5031 force-pushed the testing-authentication branch from 40ad211 to 61af2d9 Compare June 27, 2018 08:56
@anitab-org anitab-org deleted a comment Jun 27, 2018
@anitab-org anitab-org deleted a comment Jun 27, 2018
@anitab-org anitab-org deleted a comment Jun 27, 2018
@Monal5031 Monal5031 force-pushed the testing-authentication branch from 61af2d9 to 28fcc1c Compare June 28, 2018 08:04
@anitab-org anitab-org deleted a comment Jun 28, 2018
@anitab-org anitab-org deleted a comment Jun 28, 2018
@anitab-org anitab-org deleted a comment Jun 28, 2018
@anitab-org anitab-org deleted a comment Jul 8, 2018
@anitab-org anitab-org deleted a comment Jul 9, 2018
@anitab-org anitab-org deleted a comment Jul 9, 2018
@Monal5031 Monal5031 force-pushed the testing-authentication branch 2 times, most recently from 39ff714 to 46a29d4 Compare July 11, 2018 18:31
@anitab-org anitab-org deleted a comment Jul 11, 2018
@anitab-org anitab-org deleted a comment Jul 11, 2018
@anitab-org anitab-org deleted a comment Jul 11, 2018
@anitab-org anitab-org deleted a comment Jul 11, 2018
@anitab-org anitab-org deleted a comment Jul 11, 2018
@anitab-org anitab-org deleted a comment Jul 11, 2018
@naman1901 naman1901 merged commit 4fe8aeb into anitab-org:gsoc18-infra Jul 15, 2018
@Monal5031 Monal5031 deleted the testing-authentication branch July 15, 2018 10:49
anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 15, 2018
* Testing Authentication app

* Add docstrings to tests
anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 16, 2018
* Testing Authentication app

* Add docstrings to tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Program: GSOC Related to work completed during the Google Summer of Code Program. Type: Testing UI Tests, Integration Tests, Travis CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants