-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed the error shown in PUT/user Updates user profile #855
Conversation
…ers\test_update_username_already_taken() that proves my fix is effective
…est_update_username_already_taken() that proves my fix is effective
Codecov Report
@@ Coverage Diff @@
## develop #855 +/- ##
===========================================
- Coverage 95.84% 95.84% -0.01%
===========================================
Files 95 95
Lines 5199 5198 -1
===========================================
- Hits 4983 4982 -1
Misses 216 216
|
@vj-codes why are the checks failing over here🤔can anyone please review and let me know if i need to make any changes.....Thank you😊. |
@pallavisavant please resolve the merge conflicts |
@pallavisavant hey any updates abt resolving merge conflicts? |
Hey hi sry for delayed reply, I rgt now don't have the setup on my system will have to set it up again, if someone who already has it can resolve the conflicts it would be g8, I'll see if I can set up then I'll resolve 🙂 |
@pallavisavant any updates?? |
@pallavisavant I will close this PR and make the issue available due to inactivity , thank you for your contribution :) |
Description
Removed 400:Bad Request shown when user uses same username while updating users profile and changed it to 200:user was updated successfully ,allowing users to change the details even if they use same username and update other details removing bug in the current logic which makes it compulsory for user to change their username on each update . No 400:ERROR will be shown but the changed details will be reflected in users updated profile.
PS:If user can even change username on update along with other details or they can also use the already existing username and update other details.
Fixes #596
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Checklist:
Code/Quality Assurance Only