Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added description of the project #221

Merged
merged 2 commits into from
Apr 10, 2021
Merged

added description of the project #221

merged 2 commits into from
Apr 10, 2021

Conversation

shades-7
Copy link
Contributor

@shades-7 shades-7 commented Apr 2, 2021 •
edited
Loading

Description

Added project description in description meta tag in index.html
Fixes #203

Type of Change:

  • Code

Code/Quality Assurance Only

How Has This Been Tested?

Screenshot from 2021-04-08 13-17-20

Checklist:

  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@welcome
Copy link

welcome bot commented Apr 2, 2021

Hello there!👋 Welcome to the project!💖

Thank you and congrats🎉 for opening your first pull request.✨ AnitaB.org is an inclusive community, committed to creating a safe and positive environment.🌸Please adhere to our Code of Conduct and Contribution Guidelines.🙌.We will get back to you as soon as we can.😄

Feel free to join us on AnitaB.org Open Source Zulip Community.💖 We have different streams for each active repository for discussions.✨ Hope you have a great time there!😄

@Amulya-coder Amulya-coder added the Status: Needs Review PR needs an additional review or a maintainer's review. label Apr 2, 2021
devkapilbansal
devkapilbansal previously approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@devkapilbansal devkapilbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks @shades-7 for this

@devkapilbansal
Copy link
Member

@anitab-org/maintainers please review it

HeroicHitesh
HeroicHitesh previously approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@HeroicHitesh HeroicHitesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shades-7 Thanks for your contributions🎉
@devkapilbansal LGTM👍

@HeroicHitesh HeroicHitesh added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Apr 2, 2021
epicadk
epicadk previously approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@epicadk epicadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 looks good. Thankyou for your contribution

codesankalp
codesankalp previously approved these changes Apr 2, 2021
View reviewed changes
@decon-harsh
Copy link
Member

decon-harsh commented Apr 2, 2021 •
edited
Loading

Instead of industries I would suggest you to use organizations as our model has this word. Moreover industry isn't appropriate with context to this. @shades-7

IMG_20210402_102542.jpg

How about writing this?

cc @devkapilbansal @epicadk @HeroicHitesh

@Amulya-coder
Copy link
Member

Yes @decon-harsh you are right also if we see on the main page there also written the same description, Good observation 👏 @decon-harsh, @shades-7 please do the suggested changes mentioned by decon-harsh.

image

@Amulya-coder Amulya-coder added Status: Changes Requested Changes are required to be done by the PR author. and removed Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. labels Apr 2, 2021
@shades-7
Copy link
Contributor Author

shades-7 commented Apr 3, 2021

Bridge-In-Tech is an application inspired by the existing AnitaB.org Mentorship System. It encourages organizations to collaborate with the mentors and mentees on mentoring programs.

is this statement good for being description?

@Rahulm2310
Copy link
Contributor

@mtreacy002 what do you suggest ?

@mtreacy002
Copy link
Member

mtreacy002 commented Apr 3, 2021 •
edited
Loading

@shades-7 You can add an end of line comment inside a run.py (e.g. //Compulsory task - Setup environment) in the pr you're going to submit. Then once you submit the PR, inside that PR description you can add the screenshot under the "How this has been tested"). Does this make sense?

@shades-7
Copy link
Contributor Author

shades-7 commented Apr 3, 2021

@shades-7 You can add an end of line comment inside a run.py (e.g. //Cumpolsory task - Setup environment) in the pr you're going to submit. Then once you submit the PR, inside that PR description you can add the screenshot under the "How this has been tested"). Does this make sense?

This file is a bridge in tech- web with on python file.

@mtreacy002
Copy link
Member

mtreacy002 commented Apr 3, 2021 •
edited
Loading

Sorry, @shades-7 forgot that this is for frontend 🤣🤣. Then you can use that commented line in index.js for frontend perhaps? 😉

@shades-7
Copy link
Contributor Author

shades-7 commented Apr 3, 2021

Bridge-In-Tech is an application inspired by the existing AnitaB.org Mentorship System. It encourages organizations to collaborate with the mentors and mentees on mentoring programs.

is this statement good for being description?

@mtreacy002 can you check this description too

@mtreacy002
Copy link
Member

@shades-7 You can add an end of line comment inside a run.py (e.g. //Compulsory task - Setup environment) in the pr you're going to submit. Then once you submit the PR, inside that PR description you can add the screenshot under the "How this has been tested"). Does this make sense?

I misplaced this comment. This is supposed to be posted on issue #218. Sorry for the confusion, @shades-7

@mtreacy002
Copy link
Member

Bridge-In-Tech is an application inspired by the existing AnitaB.org Mentorship System. It encourages organizations to collaborate with the mentors and mentees on mentoring programs.

is this statement good for being description?

This sounds right 👍

@mtreacy002 mtreacy002 added the Category: Coding Changes to code base or refactored code that doesn't fix a bug. label Apr 4, 2021
@shades-7 shades-7 dismissed stale reviews from codesankalp and epicadk via eacfc33 April 7, 2021 08:39
@shades-7 shades-7 dismissed stale reviews from HeroicHitesh and devkapilbansal via eacfc33 April 7, 2021 08:39
@shades-7
Copy link
Contributor Author

shades-7 commented Apr 7, 2021

@Amulya-coder can you review this?

epicadk
epicadk approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@epicadk epicadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Looks good.

Amulya-coder
Amulya-coder approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@Amulya-coder Amulya-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @shades-7 🚀
Thank you for your contribution 🎉

@Amulya-coder Amulya-coder added Status: Needs Review PR needs an additional review or a maintainer's review. and removed Status: Changes Requested Changes are required to be done by the PR author. labels Apr 7, 2021
@Rahulm2310 Rahulm2310 added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Apr 7, 2021
@Rahulm2310
Copy link
Contributor

Rahulm2310 commented Apr 7, 2021 •
edited
Loading

Added Ready to merge as we 3 approvals.
cc: @mtreacy002

@epicadk
Copy link
Member

epicadk commented Apr 7, 2021

Added Ready to merge as we 3 approvals.
cc: @mtreacy002

You don't need to cc : ).

@mtreacy002
Copy link
Member

@shades-7 , just one last change before I merge the PR. Can you please replace the screenshot in the PR description under How has this been tested? to match the latest code change? Thanks 😉

@mtreacy002 mtreacy002 added Status: Changes Requested Changes are required to be done by the PR author. and removed Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. labels Apr 7, 2021
@shades-7
Copy link
Contributor Author

shades-7 commented Apr 8, 2021

@mtreacy002 done.

@epicadk epicadk added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Changes Requested Changes are required to be done by the PR author. labels Apr 8, 2021
@epicadk epicadk requested a review from mtreacy002 April 9, 2021 04:51
mtreacy002
mtreacy002 approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@mtreacy002 mtreacy002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, @shades-7 for your work. Thank you for accommodating to the change requested and contributing to the project 🎉🎉🎉

@mtreacy002 mtreacy002 merged commit 0af042f into anitab-org:develop Apr 10, 2021
@welcome
Copy link

welcome bot commented Apr 10, 2021

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreacy002 mtreacy002 mtreacy002 approved these changes

@HeroicHitesh HeroicHitesh HeroicHitesh approved these changes

@codesankalp codesankalp codesankalp approved these changes

@epicadk epicadk epicadk approved these changes

@decon-harsh decon-harsh decon-harsh approved these changes

@Aaishpra Aaishpra Aaishpra approved these changes

@Amulya-coder Amulya-coder Amulya-coder approved these changes

@devkapilbansal devkapilbansal devkapilbansal left review comments

Assignees

@shades-7 shades-7

Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Open Source Hack Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add project description in description meta tag in index.html
10 participants
@shades-7 @devkapilbansal @decon-harsh @Amulya-coder @Rahulm2310 @mtreacy002 @epicadk @HeroicHitesh @codesankalp @Aaishpra