Fast mem #9
Merged
Fast mem #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the same Trait
Instead of propagating the generic up with State, we use a trait object
and dynamic dispatch instead.
Criterion says:
Running benches/mem.rs (target/release/deps/mem-35ff881bbdbd033b)
mem set time: [1.2520 ns 1.2538 ns 1.2560 ns]
change: [-25.265% -24.900% -24.265%] (p = 0.00 < 0.05)
Performance has improved.
Found 19 outliers among 100 measurements (19.00%)
19 (19.00%) high severe
mem set full time: [82.123 µs 82.305 µs 82.527 µs]
change: [-27.445% -27.236% -27.034%] (p = 0.00 < 0.05)
Performance has improved.
Found 21 outliers among 100 measurements (21.00%)
Getting rid of dynamic dispatch would probably be even faster, but at
the cost of having State become State<T: MemoryMapper> everywhere.
Game-gear only test with gears-cli shows a 5% global performance impact
though :-/
The Cpu is now a trait, and is used dynamically instead. This version brings back the performance lost in the previous commit, and then improves 4% on top, just through by using monomorphization, just through by using monomorphization.
This will prevent forgetting about benchmarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.