Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added update notification for Linux #76

Merged
merged 4 commits into from
Feb 14, 2023
Merged

Conversation

Tommylans
Copy link
Member

@Tommylans Tommylans commented Feb 13, 2023

Signed-off-by: Tom Lanser [email protected]

For the screenshots I'm using a public Github repository but this will show to you how the updates would look like.

The ignore button will close the popup and the popup will not come back for this usage session.

image

image

@Tommylans Tommylans marked this pull request as ready for review February 13, 2023 15:20

import { FetchUpdateInformationError } from '@animo/siera-ui/src/errors/FetchUpdateInformationError'

const getLatestRelease = async (owner: string, repo: string): Promise<any> => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use Record<string, unknown>?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a reponse type with the fields that we currently use 👍

@Tommylans Tommylans merged commit c1e27e8 into main Feb 14, 2023
@Tommylans Tommylans deleted the feature/SID-118 branch February 14, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants