feat(ci): First try building on linux #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/build.yml
Outdated
| run: | | ||
| sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list | ||
| sudo apt-get update -qq | ||
| sudo apt-get install -yqq --allow-downgrades libgd3/focal libpcre2-8-0/focal libpcre2-16-0/focal libpcre2-32-0/focal libpcre2-posix2/focal |
There was a problem hiding this comment.
Do all of these specifically have to come from focal? I think we can just build it on ubuntu-latest and use the latest dependencies, right? If not, we should probably leave a comment here explaining why not the latest is being used.
.github/workflows/build.yml
Outdated
| run: yarn install --frozen-lockfile | ||
|
|
||
| - name: Build for all platforms | ||
| run: | |
There was a problem hiding this comment.
I think we should create some seperate actions for linux, Windows and macOS. This way they can run in parallel and we can use the fact that Github provides us with windows/linux/macos hosts.
Tommylans
force-pushed
the
feature/TBX-60
branch
29 times, most recently
from
6d3566e to
b4e4675
Compare
Tommylans
force-pushed
the
feature/TBX-60
branch
12 times, most recently
from
ed54d11 to
7089355
Compare
berendsliedrecht
approved these changes
Dec 21, 2022
Signed-off-by: Tom Lanser <[email protected]>
Tommylans
force-pushed
the
feature/TBX-60
branch
from
b2ae313 to
83ff4cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Lanser [email protected]