feat: Agent deletion #127
feat: Agent deletion #127
Conversation
Signed-off-by: Tom Lanser <[email protected]>
|
In other products, we use the ellipsis vertically for more options. The dropdown also feels a bit big, which doesn't bother much on the agent screen but here it's almost the size of the agent card. Maybe we can change the padding to make it a bit smaller. |
|
Made some changes from your comment 👍
|
Signed-off-by: Tom Lanser <[email protected]>
|
I meant smaller more as in less padding, primarily on the vertical sides (i think the padding is evenly on all sides now). It's also common to give it a minimal width (i think the current dropdown also has this) to make it more consistent across the app. So a bit smaller would be like Github does it; |
|
Like this?
|
Signed-off-by: Tom Lanser <[email protected]>
Tommylans
force-pushed
the
feature/G-119-agent-deletion
branch
from
f27280e to
628e9b2
Compare
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
=======================================
Coverage 76.74% 76.74%
=======================================
Files 11 11
Lines 43 43
Branches 3 2 -1
=======================================
Hits 33 33
Misses 10 10 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Can we make this alligned? 
|
| @@ -62,6 +63,14 @@ export const ConfigProvider = ({ children, configRepository }: ConfigProviderPro | |||
| setConfig(updatedConfig) | |||
| } | |||
|
|
|||
| const removeAgent = async (agentId: string) => { | |||
There was a problem hiding this comment.
@TimoGlastra I assume AFJ gives some utility on the wallet to be deleted, right?
If so, we might have to instantiate the agent here to be deleted.
Or, we would just remove all associated files, which is fairly easy but we can do that when we move to 0.4.0 as it changed there and it would add some useless code for now.
There was a problem hiding this comment.
Yep I found the delete function on the wallet. I'm currently working on a solution to initialise the wallet for the deletion 👍
There was a problem hiding this comment.
I think you don't need to initialize the wallet, as long as it has the walletConfig. But I thin you need to initialize it to get the walletConfig in currently.
We're going to revamp the wallet interface for 0.5.0, and we'll make sure to make this easier (we're thinking about a separate wallet management API that allows to create, remove, open, etc.. wallets, that is separate from the actual wallet operations such as signing ...)
|
@Tommylans Looks good. Maybe we should make the dropdowns consistent and use the three dots everywhere. The agent screen now has a chevron, and the agent card has the ellipsis. What do you think? |
Signed-off-by: Tom Lanser <[email protected]>
|
|
I couldn't really find if it was possible to actually delete the agent from the computer soooo. This was my solution within the app.
@blu3beri Do you know if this exists and if we should even remove it from the computer.
closes #119