Add some more user feedback #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-animo
force-pushed
the
feat/user-feedback
branch
from
94e88d5 to
87df0ae
Compare
|
Need some review on the copy added to make sure that it is accurate @blu3beri 😅 |
berendsliedrecht
requested changes
Mar 10, 2022
jl-animo
force-pushed
the
feat/user-feedback
branch
from
b3ec912 to
e89ef43
Compare
| ConfigurationSubcommands::View => { | ||
| debug!( | ||
| "Loaded configuration from {}", | ||
| String::from(config_path.to_str().unwrap()).bold() |
There was a problem hiding this comment.
String::from is not required here right?
There was a problem hiding this comment.
This is so that we can use bold()
jl-animo
force-pushed
the
feat/user-feedback
branch
from
1a7d6cb to
b61b784
Compare
|
@blu3beri I think I've address your feedback, would you mind taking another look? |
berendsliedrecht
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR adding a few more points of user feedback. Wanted to add these before I forgot.
Side notes
While adding this I was running into an issue creating a credential definition. Feedback:
This is actually OK feedback, but it would be really nice if we told users what they could do to fix the issue, not just that there is an issue.
Screenhots