feat: loading spinner #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Berend Sliedrecht <[email protected]>
jl-animo
reviewed
Mar 9, 2022
cli/src/utils/loader.rs
Outdated
Comment on lines
22
to
26
| pub fn start_loader(loader: Loader) { | ||
| match loader { | ||
| Loader::Spinner => spinner_loader(), | ||
| } | ||
| } |
There was a problem hiding this comment.
How does the spinner know when to stop? 😅
I have an alternate suggestion for the spinner API:
two functions: start_spinner() and stop_spinner(). Do you think something like this is possible with a reasonable amount of effort 😅 ?
Sample code:
start_spinner();
do_something_async().await;
stop_spinner();let me know what you think!
Signed-off-by: Berend Sliedrecht <[email protected]>
|
@jl-animo I resolved your feedback. with macaronis. HOWEVER.... it does break pipe sadly to jq for example. (I wonder if there is something for that..) FIXED by sending the loader to stderr |
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
morrieinmaas
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #93
Signed-off-by: Berend Sliedrecht [email protected]