Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restructured the configuration file #85

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Conversation

berendsliedrecht
Copy link
Member

  • Minor config file restructure after feedback from @TimoGlastra
  • aries-cli configuration --initialize -> aries-cli configuration initialize
  • aries-cli configuration --view -> aries-cli configuration view

Signed-off-by: Berend Sliedrecht [email protected]

@berendsliedrecht
Copy link
Member Author

@TimoGlastra the example.yaml is how you wanted it right?


```sh
aries-cli init
# or
aries-cli config --initialise
aries-cli config --initialize
```

This will create a file at `~/.config/aries-cli/config.ini` for \*NIX systems and `TODO` for Windows. It will set a default endpoint to `https://agent.community.animo.id`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For windows we now this as well now don't we?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the docs have to be rewritten. Will do at a later stage

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, sounds reasonable

@@ -38,7 +21,15 @@ impl Default for Configuration {

#[derive(Debug, PartialEq, Serialize, Deserialize)]
pub struct Configurations {
pub configurations: Vec<Configuration>,
pub configurations: BTreeMap<String, Configuration>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@@ -1,6 +1,6 @@
configurations:
- name: Default
default:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
@berendsliedrecht berendsliedrecht merged commit 7c62338 into main Mar 9, 2022
@berendsliedrecht berendsliedrecht deleted the yaml-playground branch March 9, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants