Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pkg): AUR package is changed to reflect packaging guidelines #278

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

iamwacko
Copy link
Contributor

This will fix #243 . The PKGBUILD now builds siera-cli and doesn't do any of the weird sudo curl stuff. The runner is also now an archlinux container, so it can have checksums and such.

This means the siera AUR package is no longer a binary package, but I have made and uploaded a siera-bin (made properly according to package guidelines) basically does what the old siera package used to do. I could put that in the build process and hand over the package, if you want me to.

@TimoGlastra
Copy link
Member

Hey @iamwacko, thanks for looking into this and opening a PR. @berendsliedrecht is away for the week, he'll take a look at this when he's back next week

@TimoGlastra
Copy link
Member

@berendsliedrecht bump on this one

Copy link
Member

@berendsliedrecht berendsliedrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment regarding the $CARCH check.

Thanks for the contribution!

Comment on lines +16 to +17
case $CARCH in
"pentium4")
Copy link
Member

@berendsliedrecht berendsliedrecht Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the proper check for this? Shouldn't we use arch?

Copy link
Contributor Author

@iamwacko iamwacko Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically yeah, but with archlinux32 the $CARCH isn't usually i686, so it wouldn't properly compile. I have a few computers running archlinux32, so it's a habit I've picked up.

It doesn't matter too much, I doubt anyone's going to run siera-cli on their 17 year old computer, so you could remove it if you want.

@berendsliedrecht
Copy link
Member

@iamwacko could you rebase with main? audit is failing but that is fixed now in `main. Thanks!

@iamwacko
Copy link
Contributor Author

iamwacko commented Feb 5, 2024

@iamwacko could you rebase with main? audit is failing but that is fixed now in `main. Thanks!

Ok, done

@berendsliedrecht berendsliedrecht merged commit b86913e into animo:main Feb 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct PKGBUILD for AUR release
3 participants