-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pkg): AUR package is changed to reflect packaging guidelines #278
Conversation
Hey @iamwacko, thanks for looking into this and opening a PR. @berendsliedrecht is away for the week, he'll take a look at this when he's back next week |
@berendsliedrecht bump on this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment regarding the $CARCH
check.
Thanks for the contribution!
case $CARCH in | ||
"pentium4") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the proper check for this? Shouldn't we use arch
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically yeah, but with archlinux32 the $CARCH isn't usually i686, so it wouldn't properly compile. I have a few computers running archlinux32, so it's a habit I've picked up.
It doesn't matter too much, I doubt anyone's going to run siera-cli on their 17 year old computer, so you could remove it if you want.
@iamwacko could you rebase with main? |
Ok, done |
This will fix #243 . The PKGBUILD now builds siera-cli and doesn't do any of the weird sudo curl stuff. The runner is also now an archlinux container, so it can have checksums and such.
This means the siera AUR package is no longer a binary package, but I have made and uploaded a siera-bin (made properly according to package guidelines) basically does what the old siera package used to do. I could put that in the build process and hand over the package, if you want me to.