Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: basic messages #27

Merged
merged 6 commits into from
Dec 15, 2021
Merged

feat: basic messages #27

merged 6 commits into from
Dec 15, 2021

Conversation

berendsliedrecht
Copy link
Member

@berendsliedrecht berendsliedrecht commented Dec 12, 2021 •
edited
Loading

  • send basic message to any connection via the id

closes #6

@berendsliedrecht
feat: feature discovery
017bce8 
Signed-off-by: Berend Sliedrecht <[email protected]>
@berendsliedrecht
refactor: minor clean up
cc827cd 
Signed-off-by: Berend Sliedrecht <[email protected]>
@berendsliedrecht
feat: connections subcommand
eeae0ed 
Signed-off-by: Berend Sliedrecht <[email protected]>
@berendsliedrecht
feat: added clippy and makefile
f7925ed 
Signed-off-by: Berend Sliedrecht <[email protected]>
@berendsliedrecht
feat: added cargo doc to makefile
cb68ab3 
Signed-off-by: Berend Sliedrecht <[email protected]>
@berendsliedrecht
feat: basic messages
67e83cc 
Signed-off-by: Berend Sliedrecht <[email protected]>
@berendsliedrecht berendsliedrecht changed the title feat: basic messagesd feat: basic messages Dec 12, 2021
morrieinmaas
morrieinmaas reviewed Dec 14, 2021
View reviewed changes
Copy link
Contributor

@morrieinmaas morrieinmaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Maybe as an addition (for another PR/as an idea it'd be cool to be able to provide a file path to a file that has a message

@berendsliedrecht berendsliedrecht merged commit 67e83cc into main Dec 15, 2021
@berendsliedrecht berendsliedrecht deleted the feat/basic-message branch December 23, 2021 09:15
gitbook-com bot pushed a commit that referenced this pull request Apr 4, 2022
@anagoessens @gitbook-bot
GitBook: [#27] No subject
13f919a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrieinmaas morrieinmaas morrieinmaas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

send basic message
2 participants
@berendsliedrecht @morrieinmaas